cmake: set PCRE2POSIX_CFLAG in pcre2-config and pkg-config #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a8a875e (windows: integrate visibility attributes without conflicts (PCRE2Project#249), 2023-05-16) setting CFLAGS when using a DLL is recommended, but the pcre2-config and pkgconfig files generated by cmake didn't include that logic, unlike the ones generated by the autotools. While at it, refactor the code so it will be more modern and it wouldn't unnecessarily install the pcre2posix pkgconfig if not needed and make sure the generated pcre2-config uses UNIX EOL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an edge case from #249 for a library that was installed by cmake but that is built against using a different method.