pcre2posix: additional updates for recent changes #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenas
changed the title
Somehow previous fix was not ammended to include this code change, take the opportunity to update ChangeLog and do other cleanup so it will be at least worth a PR. Those found responsible have been sacked
Since 0710ce2 (pcre2posix: avoid snprintf quirks in regerror (PCRE2Project#333), 2023-11-15), a call for snprintf was replaced by a pair of strncpy and buf[errbuf_size - 1] = 0, but it didn't account for the case where errbuf_size == 0. Make the code conditional to mimic the original logic and avoid crashing.
POSIX 1003.1-2008 requires that regoff_t be at least as large as ssize_t or ptrdiff_t, but we use int and therefore any match is restricted to what that can hold, even in 64-bit architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally meant as a "fixup" for the changes introduced in #333, but includes additional changes that are shown independently in case they need to be dropped, albet it includes a critical brown bag patch that fixes a crash on the original code.
pcre2_regerror(.., .., NULL, 0)or equivalent is used.There is actually a fourth patch that actually tightens the issues raised about overlong buffers, but it is not included in this series but kept on its own branch, let me know if you would rather had everything squashed there and in a different PR instead, I will squash them as you prefer, but will suggest getting the first two ASAP otherwise.