Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally enable differential fuzzing #381

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

addisoncrump
Copy link
Contributor

Unfortunately, there was an unexpected blocker on google/oss-fuzz#11195 -- differential fuzzing support finding aborts made the build unacceptable for OSS-Fuzz, as these issues appear quite quickly.

This PR fixes it by making differential fuzzing conditional, while keeping fuzzing enabled for JIT and for the interpreter.

@addisoncrump
Copy link
Contributor Author

addisoncrump commented Feb 16, 2024

Should config.h.in be gitignored? It looks like we have two conflicting versions of autoheader.

@PhilipHazel PhilipHazel merged commit 30a3acd into PCRE2Project:master Feb 16, 2024
10 checks passed
@PhilipHazel
Copy link
Collaborator

There are sure to be people who clone the repo and then expect config.h.in to be there for building, and if we gitignore it somebody will be caught out. No doubt either you or I will update our autotools at some point and this issue will go away. i am on Arch Linux, which I keep fairly up to date. I am currently on autoheader 2.72.

Luckily I had taken a break for lunch from making a new release, so I have managed to include this merge, but will now proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants