Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build.zig to support zig 0.13.0 #416

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

player-two
Copy link
Contributor

The cache director is now prefixed with a .0

Also, std.Build.LazyPath has changed, and now the recommended way to create one that is relative to the repo root is via std.Build.path().

Copy link
Contributor

@carenas carenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while 0.13.0 is the highest numbered release, it would be nice to keep this backward compatible as much as possible, specially considering that 0.12.1 was released after 0.13.0

@@ -99,6 +99,6 @@ src/stamp-h1
/bazel-*

zig-out/
zig-cache/
Copy link
Contributor

@carenas carenas Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this line so it also works for zig 0.12.x?

FWIW the rest of the changes are compatible zig 0.12.0 or later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course 👍

The cache director is now prefixed with a .[0]

Also, std.Build.LazyPath has changed, and now the recommended way to create one
that is relative to the repo root is via std.Build.path().

[0]: https://ziglang.org/download/0.13.0/release-notes.html#codezig-cachecode-renamed-to-codezig-cachecode
@player-two player-two force-pushed the jgriege/zig-0.13.0 branch from 9397b5c to d7251e9 Compare June 11, 2024 14:51
@PhilipHazel PhilipHazel merged commit 967804b into PCRE2Project:master Jun 11, 2024
11 checks passed
@player-two player-two deleted the jgriege/zig-0.13.0 branch December 31, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants