Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m4/pcre2_visibility.m4: add basic support for non GCC compilers #421

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Jun 11, 2024

Tested with the latest version of SunPro and TinyCC. It would also allow for other clang proprietary derivatives.

As usual, would fall cleanly for the cases where there is no support for -fvisibility

@PhilipHazel
Copy link
Collaborator

This patch has broken the CIFuzz automatic check somehow.

Assume that a compatible `-fvisibility=hidden` option is available
and that the compiler handles correctly `#warning` macros.

Restrict the visibility test if `-Werror` is unrealiable to protect
for compilers like xlc or systems like cygwin that might allow the
compiler flag without errors but wouldn't work.

While at it, lower the minimum autoconf required to the one that
introduced the latest macros and tested in OpenBSD 7.5 with automake
1.9.
@PhilipHazel PhilipHazel merged commit 430237f into PCRE2Project:master Jun 12, 2024
11 checks passed
@carenas carenas deleted the autovis branch June 12, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants