Patch: Re-run PPT_ONCE_ON_LOAD patches when enabling them as the game is running #12165
+47
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type 2 patches were supposed to be "Type 0 + Type 1", but in reality they only executed on vblank, making them equivalent to Type 1.
F0bes
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR introduces two changes:
PPT_COMBINED_0_1were erroneously working identical to the Type 1 patches, as they were not applying in the entrypoint, contrary to what the docs claimed.PPT_ONCE_ON_LOADthat are enabled while the game is running are now being applied immediately, without requiring a restart. Without this change, one-time patches were effectively at a disadvantage compared to the every-frame patches, as the user could not enable them on runtime, even if they were safe to do so.Rationale behind Changes
Stop punishing one-time patches for trying to be nice and not overwriting the code over and over every frame.
Suggested Testing Steps