Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update error links to pagerduty docs #66

Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix: update error links to pagerduty docs #66

merged 2 commits into from
Feb 6, 2024

Conversation

codingdiaz
Copy link
Contributor

@codingdiaz codingdiaz commented Feb 6, 2024 •
edited by t1agob
Loading

Description

The error components are still linked to the backstage GitHub repository. For example, the READ MORE button below went to a misleading link.

Screenshot 2024-02-06 at 10 17 17 AM

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

t1agob and others added 2 commits January 31, 2024 21:44
@t1agob
relese: 0.8.3 (PagerDuty#65)
e6baf12 
### Description

This release fixes an issue (PagerDuty#63) that was causing an error message to
show on-screen for user accounts that don't have AIOPs or Event
Intelligence capabilities.


![image](https://github.com/PagerDuty/backstage-plugin/assets/2689939/020d8654-49c1-43fa-8769-f001195f1b0e)

With this change instead of getting an out-of-context error message,
users will see the following image and message instead.


![image](https://github.com/PagerDuty/backstage-plugin/assets/2689939/5554c2ec-0549-4e40-8d34-b4acecc8e8f5)

## Acknowledgement

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

**Disclaimer:** We value your time and bandwidth. As such, any pull
requests created on non-triaged issues might not be successful.
@codingdiaz
fix: update error links to pagerduty docs
3ecb3d3
@codingdiaz codingdiaz requested a review from t1agob as a code owner February 6, 2024 16:25
@t1agob t1agob added the bug Something isn't working label Feb 6, 2024
@t1agob t1agob changed the base branch from main to next February 6, 2024 16:56
t1agob
t1agob approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@t1agob t1agob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Totally missed this one.

@t1agob t1agob merged commit cc4a34f into PagerDuty:next Feb 6, 2024
1 check passed
@t1agob
Copy link
Contributor

t1agob commented Feb 6, 2024

This is now merged into next and will be merged to main in the next release. Thanks @codingdiaz!

@codingdiaz
Copy link
Contributor Author

This is now merged into next and will be merged to main in the next release. Thanks @codingdiaz!

Awesome! Thanks for accepting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t1agob t1agob t1agob approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingdiaz @t1agob