Skip to content

Commit

Permalink
build(requirements): pin 'itsdangerous' to < 2.1
Browse files Browse the repository at this point in the history
'flask-oidc' 1.4.0 (latest) still use 'JSONWebSignatureSerializer' which was removed in 'itsdangerous' v2.1.
Until puiterwijk/flask-oidc#144 is merged and a new version of flask-oidc is released,
it's necessary to pin 'itsdangerous' to a version below 2.1 if 'flask-oidc' is used.

References:
puiterwijk/flask-oidc#147
https://itsdangerous.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
  • Loading branch information
wombelix committed Jan 22, 2023
1 parent efc12ec commit 7d6573a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions requirements-testing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ cryptography <= 36.0.0
eventlet <= 0.33.2
fedmsg <= 1.1.2
flake8 <= 4.0.1

# Important: Until https://github.com/puiterwijk/flask-oidc/pull/144 is merged and a new version of flask-oidc is released,
# it's necessary to ensure `itsdangerous` is pinned to a version lower as 2.1 as well.
flask-oidc <= 1.4.0
itsdangerous < 2.1

mock <= 4.0.3
pagure-messages >= 0.0.1
pytest <= 6.2.5
Expand Down
3 changes: 3 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ whitenoise <= 6.2.0
wtforms <= 3.0.1

# Required only for the `oidc` authentication backend
# Important: Until https://github.com/puiterwijk/flask-oidc/pull/144 is merged and a new version of flask-oidc is released,
# it's necessary to ensure `itsdangerous` is pinned to a version lower as 2.1 as well.
# flask-oidc <= 1.4.0
# itsdangerous < 2.1

# Required only if `USE_FLASK_SESSION_EXT` is set to `True`
# flask-session
Expand Down

0 comments on commit 7d6573a

Please sign in to comment.