This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
ci: increase the default apply timeout #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoSix
force-pushed
the
apply_timeout-increase
branch
from
3d5ded7 to
d947ac6
Compare
michalbil
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase
apply_timeoutfor infrastructure building workflows.Motivation and Context
Since our code can sometimes be quite complex, default 30 minutes might not be enough to perform apply or idempotence tests. This gives an option to override this property from the calling workflow level.
Additionally, chatops command had no possibility to override this parameter. This change adds that possibility.
Important
DO NOT MERGE BEFORE -> PaloAltoNetworks/terraform-modules-swfw-ci-workflows#72
How Has This Been Tested?
tested on Azure repo copy
Screenshots (if appropriate)
Types of changes
Checklist