Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

refactor(module/vnet_peering)!: module refactor and adjusted examples #355

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

acelebanski
Copy link
Contributor

Description

PR delivers changes for vnet_peering:

  • README.md adjusted to new style with additional header file
  • minimum Terraform version set to 1.3
  • refactor variables:
    • descriptions
    • types with optionals
    • default values
    • validations
  • simplify main.tf by removing not required try
  • remove name generation logic from the module
  • add terraform registry reference

Motivation and Context

#336

How Has This Been Tested?

I checked that module using "test_infrastructure" example.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski requested a review from a team as a code owner November 5, 2023 13:20
@acelebanski acelebanski changed the title Refactored module and relevant examples refactor(module/vnet_peering)!: module refactor and adjusted examples Nov 5, 2023
Copy link
Contributor

@FoSix FoSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
just this one space missing in the variables

modules/vnet_peering/variables.tf Outdated Show resolved Hide resolved
@acelebanski acelebanski merged commit 60ba789 into 307-refactor-modules Nov 7, 2023
@acelebanski acelebanski deleted the 336-vnet_peering-refactor branch November 7, 2023 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants