refactor: vmss + application insights #360

FoSix · 2023-11-16T13:30:33Z

No description provided.

FoSix · 2023-11-16T13:31:34Z

/help

ChatOPS built in help:

Currently supported commands include:

/sca - run all SCA tests via pre-commit
/validate - run terraform validate
/plan - plan the infrastructure (only examples)
/apply - deploy the infrastructure and destroy afterwards (only examples)
/idempotence - test idempotence: deploy, plan and destroy afterwards (only examples).

The 1^st command does not take arguments, the remaining take two:

paths - a space delimitied list of module paths
tf_version - (optional, defaults to the latest available) a space delimited list of Terraform versions to test the infrastrucure against.

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/common_vmseries examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"

# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vnet examples/dedicated_vmseries"

FoSix · 2023-11-16T13:32:53Z

/idempotence paths="examples/common_vmseries_and_autoscale examples/dedicated_vmseries_and_autoscale" tf_version="1.3 1.4 1.5 1.6"

Testing job ID: 6891470932
Job result: FAILURE

FoSix · 2023-11-16T14:50:52Z

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6"

Testing job ID: 6892413937
Job result: FAILURE

acelebanski

Looks good to me, let's merge if tested with all relevant examples.

FoSix · 2023-12-08T11:17:33Z

/idempotence paths="examples/common_vmseries_and_autoscale examples/dedicated_vmseries_and_autoscale" tf_version="1.5 1.6"

Testing job ID: 7140698442
Job result: SUCCESS

FoSix · 2023-12-21T09:42:48Z

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6"

Testing job ID: 7286475574
Job result: FAILURE
Job result: FAILURE
Job result: FAILURE
Job result: SUCCESS

FoSix · 2023-12-22T10:20:24Z

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6"

Testing job ID: 7298785291
Job result: SUCCESS

sebastianczech

Awesome job 👍

modules/ngfw_metrics/main_test.go

modules/ngfw_metrics/versions.tf

sebastianczech · 2023-12-22T13:20:55Z

modules/vmss/main.tf

+
+  admin_username                  = var.authentication.username
+  admin_password                  = var.authentication.disable_password_authentication ? null : local.password
+  disable_password_authentication = var.authentication.disable_password_authentication


What do you think about getting rid of var.authentication.disable_password_authentication and use:

disable_password_authentication = length(var.authentication.ssh_keys) > 0 && var.authentication.password == null

?

I think the idea for this was to allow having both SSH key & password for authentication.

modules/vmss/main.tf

sebastianczech · 2023-12-22T13:33:55Z

modules/vmss/variables.tf

+      end_time   = string
+    }))
+    scale_rules = optional(list(object({
+      name = string


What do you think about adding validation if name is from 10 possible metrics:

DataPlaneCPUUtilizationPct DataPlanePacketBufferUtilization panGPGatewayUtilizationPct panGPGWUtilizationActiveTunnels panSessionActive panSessionConnectionsPerSecond panSessionSslProxyUtilization panSessionThroughputKbps panSessionThroughputPps panSessionUtilization

?

but name can be also a name of the built-in metric, we would have to maintain that list and follow changes on Azure. I'm not a fan of that :)

modules/vmss/main.tf

FoSix added 15 commits November 2, 2023 14:43

done to interfaces

538daef

update readme

7d96b82

Merge branch '307-refactor-modules' into 335-vmss-refactor

e6445fc

nics

bb16e2a

autoscaling configuration

fed73ad

update gitignore to ignore certificates

69cef9f

added autoscaling, tested and working in basic configuration

4ed0e47

scale out based on a schedule

e4fb419

introduce ngfw_metrics

7943068

ngfw module documentation

ab29586

vmss module documentation

92f9821

dt_string_converter documentation

a8f233d

adjusted common autoscaling example

0765820

Merge branch '307-refactor-modules' into 335-vmss-refactor

a6d5ec4

autoscaling example updated

6bf6996

FoSix marked this pull request as ready for review November 17, 2023 08:17

FoSix requested a review from a team as a code owner November 17, 2023 08:17

update standalone examples with ngfw_metrics module

b7a2c95

FoSix force-pushed the 335-vmss-refactor branch from 193f8cd to b7a2c95 Compare November 17, 2023 08:37

FoSix added the refactor label Nov 17, 2023

FoSix added 2 commits November 17, 2023 11:27

fix gwlb deploy problems

ce157cd

adding in-code documentation around the autoscaling profiles definition

a654ccd

acelebanski approved these changes Dec 5, 2023

View reviewed changes

FoSix added 2 commits December 7, 2023 13:00

storage_account_type -> disk_type rename

4e083b4

update and allign variable names

54dc635

FoSix force-pushed the 335-vmss-refactor branch from daf4c2d to 18d1458 Compare December 8, 2023 11:48

FoSix force-pushed the 335-vmss-refactor branch from 18d1458 to b24a7d1 Compare December 8, 2023 14:19

FoSix marked this pull request as draft December 8, 2023 14:21

"one" -> 1 in dynamic loops, to keep code coherent

e32a009

FoSix force-pushed the 335-vmss-refactor branch from b24a7d1 to e32a009 Compare December 8, 2023 14:48

FoSix added 2 commits December 21, 2023 10:29

vmss + metrics - final version

035a50a

merge 307

d76571e

FoSix added 2 commits December 21, 2023 11:14

Merge branch '307-refactor-modules' into 335-vmss-refactor

c0cd48a

fixing default values for Appgw

2ee4e1f

FoSix force-pushed the 335-vmss-refactor branch from 523c051 to 2ee4e1f Compare December 21, 2023 15:57

FoSix marked this pull request as ready for review December 21, 2023 16:40

FoSix requested review from acelebanski and sebastianczech December 21, 2023 16:40

remove proximity placement group

6ffc8d7

sebastianczech reviewed Dec 22, 2023

View reviewed changes

acelebanski reviewed Jan 4, 2024

View reviewed changes

modules/vmss/main.tf Show resolved Hide resolved

FoSix added 2 commits January 5, 2024 08:38

apply suggestions from comments

c9cc739

keep locals next to the resource they are being used in

d6d2780

FoSix merged commit 7e8b486 into 307-refactor-modules Jan 5, 2024

FoSix deleted the 335-vmss-refactor branch January 5, 2024 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: vmss + application insights #360

refactor: vmss + application insights #360

FoSix commented Nov 16, 2023

FoSix commented Nov 16, 2023 •

edited by github-actions bot

Loading

FoSix commented Nov 16, 2023 •

edited by github-actions bot

Loading

FoSix commented Nov 16, 2023 •

edited by github-actions bot

Loading

acelebanski left a comment

FoSix commented Dec 8, 2023 •

edited by github-actions bot

Loading

FoSix commented Dec 21, 2023 •

edited by github-actions bot

Loading

FoSix commented Dec 22, 2023 •

edited by github-actions bot

Loading

sebastianczech left a comment

sebastianczech Dec 22, 2023 •

edited

Loading

acelebanski Jan 4, 2024

FoSix Jan 4, 2024

sebastianczech Dec 22, 2023

FoSix Jan 4, 2024

refactor: vmss + application insights #360

refactor: vmss + application insights #360

Conversation

FoSix commented Nov 16, 2023

FoSix commented Nov 16, 2023 • edited by github-actions bot Loading

ChatOPS built in help:

FoSix commented Nov 16, 2023 • edited by github-actions bot Loading

FoSix commented Nov 16, 2023 • edited by github-actions bot Loading

acelebanski left a comment

Choose a reason for hiding this comment

FoSix commented Dec 8, 2023 • edited by github-actions bot Loading

FoSix commented Dec 21, 2023 • edited by github-actions bot Loading

FoSix commented Dec 22, 2023 • edited by github-actions bot Loading

sebastianczech left a comment

Choose a reason for hiding this comment

sebastianczech Dec 22, 2023 • edited Loading

Choose a reason for hiding this comment

acelebanski Jan 4, 2024

Choose a reason for hiding this comment

FoSix Jan 4, 2024

Choose a reason for hiding this comment

sebastianczech Dec 22, 2023

Choose a reason for hiding this comment

FoSix Jan 4, 2024

Choose a reason for hiding this comment

FoSix commented Nov 16, 2023 •

edited by github-actions bot

Loading

FoSix commented Nov 16, 2023 •

edited by github-actions bot

Loading

FoSix commented Nov 16, 2023 •

edited by github-actions bot

Loading

FoSix commented Dec 8, 2023 •

edited by github-actions bot

Loading

FoSix commented Dec 21, 2023 •

edited by github-actions bot

Loading

FoSix commented Dec 22, 2023 •

edited by github-actions bot

Loading

sebastianczech Dec 22, 2023 •

edited

Loading