-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage 030 update #73
Stage 030 update #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don`t see how changes from e3c85e6 (CSV file with "hashtags" and "physics short" for datasets) are used.
I believe that this commit would be better for another branch, where mentioned "extensions" do appear.
Two others will be accepted as they are. Thank you!
But, for the future:
- it is a good idea to describe errors that was fixed, so that one who stumbled on it knew it was fixed (5fa3369);
- same for the improved regular expression (6c3d04b): what changed after this improvements? what cases it failed to detect (or detected erroneously) before so that this improvement is needed?
It is good at least because when you yourself try to reconstruct your thoughts a year after now, you might already forget what is obvious for now. No to mention people who tries to understand your thoughts right now ;)
CSV file - i added it because i thought that it was better than either:
Error - makes sense, will try to keep that in mind. Regular expression - this change is solving #46. When this pull request will be merged, issue will be closed and commit/request will be linked in it. I can link issue here or in pull request initial message, but not in commit message (i think). |
@Evildoor, However if there are too many branches, and you`d like to avoid [1] As Git is not interested in any directory unless it has at least one tracked file, to add an empty dir is a tricky thing. But you can add something like README file to it, where you are going to make notes about "which data are for which extension" (if it is a directory for source data only) or describing extensions themselves (if their code to be stored in it as well), or something. |
I doubt that there will be too many branches with different extensions, but idea of creating "stage-30-extensions" branch looks appealing to me. Will do. |
This solves a problem described in Issues, link will be made.
Starting to add papers and pressing "Cancel" in the dialogue lead to "fnames" variable being not what the program expected. Check was added to prevent this.
5fa3369
to
07f5696
Compare
Removed commit related to extensions, updated descriptions for other ones. |
@mgolosova |
@Evildoor, |
@Evildoor , |
Small update with changes serving for:
Creating a base for extension development.(Removed per conversation below.)