Kill process causing make boot to hang

PandABlocks · Oct 9, 2024 · c1a750e · c1a750e
1 parent ab3998b
commit c1a750e
Showing 1 changed file with 2 additions and 14 deletions.
diff --git a/.github/workflows/_make_boot.yml b/.github/workflows/_make_boot.yml
@@ -31,29 +31,17 @@ jobs:
       # Generate bootable image
       - name: Make boot
         id: make_boot
-        continue-on-error: true
-        #timeout set to expected upper-limit of build
-        timeout-minutes: 60
         run: |
           echo "boot_files=false" >> $GITHUB_OUTPUT
           cd repos/PandABlocks-fpga
           ln -s CONFIG.example CONFIG
           make boot APP_NAME=${{ matrix.app }}
-          if test -f /build/boot*.zip; then
-            echo "boot_files=true" >> $GITHUB_OUTPUT
-          fi
-
-      # Current workflow hangs upon make_boot completion, requiring a timeout
-      # Envvar boot_files is set true if timeout reached after successful boot build
-      # Envvar boot_files is set false on boot build error and/or failure to generate zip files
-      - name: Fail workflow if boot files absent
-        if: ${{ steps.make_boot.outputs.boot_files == 'false'}}
-        run: exit 1
+          ps -Ao pid= -o comm= | awk '$2 ~ /Xvfb/ { print $1}' | xargs kill
 
       # Upload artifacts if boot files present
       - name: Upload boot
         if: ${{ steps.make_boot.outputs.boot_files == 'true'}}
         uses: actions/upload-artifact@v4
         with:
           name: boot-${{ matrix.app }}
-          path: /build/boot*.zip
+          path: /build/boot*.zip