Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for adding additional io #218

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomtrafford
Copy link
Contributor

resolves #193.

@glennchid Would you say this description is easy to follow? I'm wondering if it doesn't read that well - I'm happy to re-write it.

@tomtrafford tomtrafford requested a review from glennchid October 21, 2024 09:24
glennchid
glennchid previously approved these changes Oct 21, 2024
Copy link
Contributor

@glennchid glennchid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions..

docs/reference/block.rst Outdated Show resolved Hide resolved
docs/reference/block.rst Outdated Show resolved Hide resolved
docs/reference/block.rst Outdated Show resolved Hide resolved
docs/reference/block.rst Show resolved Hide resolved
@glennchid
Copy link
Contributor

resolves #193.

@glennchid Would you say this description is easy to follow? I'm wondering if it doesn't read that well - I'm happy to re-write it.

I think it is okay, though a few minor suggestions above. Might be better though to get somebody not familiar with the changes to review and see if it is understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Documentation for using SFP through FMC interface
2 participants