Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .chd mimetype icon, and update the MAME icon to match #3891

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

achadwick
Copy link
Contributor

Adds an icon for .chd files based on the existing icons for qemu and vmware disk images,

application-x-mame-chd@64x64 application-x-mame-chd@48x48 application-x-mame-chd@32x32 application-x-mame-chd@24x24 application-x-mame-chd@22x22 application-x-mame-chd@16x16

and updates the existing MAME app icon's colours to be closer the "M" of the the wordmark used on https://mamedev.org currently, and reflect the colours for the new mimetype:

mame@64x64 mame@48x48 mame@32x32 mame@24x24 mame@22x22 mame@16x16

The .chd format is pretty generic, and can store CD images too. Unrelated PlayStation emulators will use it for that, even though the format started off with MAME and is mostly used for HD images. It's not really MAME-specific now, and the existing qchdman icon just reflects the hard disk icons, as the format's major use.

I think honestly the design for hard disk files like this and the existing application-x-{vmware,qemu}-disk icons could be abstracted to just the central circle-with-a-quarter-spur design, and thus made closer to the existing application-x-iso icon. The concepts are very close to .iso images, after all. What do you think? Should I update those disk image icons too?

Related to #2505.

@achadwick achadwick marked this pull request as draft January 5, 2025 02:13
@achadwick
Copy link
Contributor Author

Actually, I want to tweak the mimetype's hues a bit more before declaring this one ready for review. Forgive the noise.

Compressed Hunk of Data, not always a hard disk. Often used for
the hard disk that accompanies the ROM chips on some arcade
boards. The file format is used by other emulators too,
PlayStation ones, notably. For those, it's a CD.

Same iconography as the existing qchdman icon. Colours like
the MAME branding, electric blue on black. Design from the
existing application-x-qemu-disk icon.
The MAME wordmark on mamedev.org uses a considerably lighter
electric blue than the old icon here. Lift the MAME icon to be a
bit closer to the new CHD mimetype icon without washing out on
light theme backgrounds.
@achadwick
Copy link
Contributor Author

application-x-mame-chd@64x64 application-x-mame-chd@48x48 application-x-mame-chd@32x32 application-x-mame-chd@24x24 application-x-mame-chd@22x22 application-x-mame-chd@16x16

Hopefully a closer hue match now. Let me know whether I should revisit this and the other hard disk image icons to be closer in spirit to the .iso icons.

@achadwick achadwick marked this pull request as ready for review January 5, 2025 02:23
@achadwick achadwick mentioned this pull request Jan 5, 2025
30 tasks
@morganist
Copy link
Member

I think honestly the design for hard disk files like this and the existing application-x-{vmware,qemu}-disk icons could be abstracted to just the central circle-with-a-quarter-spur design, and thus made closer to the existing application-x-iso icon.

i guess that could be done, but these are device icons, and the hard drive device icon is the one you've used. for the sake of consistency, i think it's better to leave similar icons this way

@morganist morganist merged commit 1a75cb1 into PapirusDevelopmentTeam:master Jan 15, 2025
@achadwick achadwick deleted the mame-chd-mimetype branch January 15, 2025 23:30
@morganist
Copy link
Member

congrats on making one of the lightest app icons in Papirus history, by the way!

@achadwick
Copy link
Contributor Author

congrats on making one of the lightest app icons in Papirus history, by the way!

Not my doing! All @Vectrex's original work in 720f7de and a bit of cleanup by @SmartFinn subsequently: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commits/master/Papirus/64x64/apps/mame.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants