Skip to content

Commit

Permalink
Update cran-comments
Browse files Browse the repository at this point in the history
  • Loading branch information
PaulRegular committed Apr 5, 2022
1 parent 18459da commit 051fe66
Showing 1 changed file with 11 additions and 18 deletions.
29 changes: 11 additions & 18 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
## Release summary

- In addition to some minor improvements, this version fixes a failing tests under r-devel ("Error: invalid 'size' argument"). Values supplied to the 'size' argument in sample.int are now length == 1, therefore passing a new error trap in sample.int.
- In addition to some minor improvements, this patch fixes an error associated with a donttest check, specifically with the use of a logical expression with length > 1. A plotly call was supplied a logical vector when a logical object of length 1 should have been provided.

## Test environments

- local R installation, R 4.1.2
- ubuntu 16.04 (on travis-ci), R 4.1.2
- Github Actions ubuntu-latest (release, devel, oldrel-1),
- GitHub Actions windows-latest (release)
- win-builder (devel)
- R-hub windows-x86_64-devel (r-devel)
- R-hub fedora-clang-devel (r-devel)
- R-hub ubuntu-gcc-release (r-release)

## R CMD check results

> On windows-x86_64-devel (r-devel), fedora-clang-devel (r-devel), ubuntu-gcc-release (r-release)
## R CMD check results
> On windows-x86_64-devel (r-devel), fedora-clang-devel (r-devel)
checking CRAN incoming feasibility ... NOTE
Maintainer: 'Paul Regular <Paul.Regular@dfo-mpo.gc.ca>'

Expand All @@ -25,27 +26,19 @@
> On windows-x86_64-devel (r-devel)
checking package dependencies ... NOTE
Package suggested but not available for checking: 'INLA'
* checking for detritus in the temp directory ... NOTE

> On windows-x86_64-devel (r-devel)
checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'

> On fedora-clang-devel (r-devel)
* checking examples ... NOTE
checking examples ... NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
sim_survey 9.644 0.471 1.965
run_strat 7.009 0.228 1.536
strat_error 5.742 0.183 0.760
** found \donttest examples: check also with --run-donttest

> On ubuntu-gcc-release (r-release)
* checking examples ... NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
run_strat 8.217 0.057 2.038
user system elapsed
run_strat 6.06 0.275 2.349
** found \donttest examples: check also with --run-donttest

0 errors √ | 0 warnings √ | 4 notes x



0 comments on commit 051fe66

Please sign in to comment.