-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anticipation Velocity Model (AVM) #1432
Anticipation Velocity Model (AVM) #1432
Conversation
- This change is to make sure, I'm using my own version. - Will be reversed when I'm done
TODO: _JPS_Agent_GetCollisionFreeSpeedModelV3State can not be found when importing jupedsim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should consider another name for this model. CFSMv3 implies a direct evolution on v2. I am not sure if this really is the case or if there is more novelty to it.
@xuqiancheng I think the model is ready for your review. Can you please check if the equations are implemented correctly according to the model? We can not yet use the model though, due to lack of the python-API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the code, except for the function BoundaryRepulsion, other equations of the AVM are implemented correctly.
- smooth changes - change whenever too close
ded353a
to
c10dd33
Compare
const Point& predictedDirection) const | ||
{ | ||
// Eq. (5) | ||
static std::mt19937 gen(42); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The seed needs to become a model parameter. Otherwise I think this will become a breaking change later on.
Now ignores compile_commands.json and clangd cache
…i/jupedsim into CollisionFreeSpeedModelV3
3541bf4
to
e7579f8
Compare
…i/jupedsim into CollisionFreeSpeedModelV3
In this PR, the model Anticipation in a velocity-based model for pedestrian dynamics
is implemented.
AntiTime
,ConstantAlpha