Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LK adjoint test skip #1048

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 24, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Some tests in Adjoint Jacobian were previously skipped for Lightning Kokkos (before native controlled gates were implemented).

Description of the Change:
The pytest skips are removed.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 24, 2025
@josephleekl josephleekl marked this pull request as ready for review January 24, 2025 16:47
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (25e6517) to head (a9f729d).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (25e6517) and HEAD (a9f729d). Click for more details.

HEAD has 35 uploads less than BASE
Flag BASE (25e6517) HEAD (a9f729d)
43 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
- Coverage   98.10%   92.70%   -5.40%     
==========================================
  Files         233      112     -121     
  Lines       39079    16990   -22089     
==========================================
- Hits        38339    15751   -22588     
- Misses        740     1239     +499     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants