Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mac test pipeline from storage repos #3324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

v01dstar
Copy link
Contributor

@v01dstar v01dstar commented Jan 22, 2025

TiKV's RocksDB's fork's CI disabled mac build anyway. And mac build is too slow in Titan's and rust-rocksdb's CI. So, disable mac build across storage repos' (RocksDB, Titan, rust-rocksdb) CI.

Copy link

ti-chi-bot bot commented Jan 22, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and diff, it seems that the change removes the test_mac pipeline from the titan_ghpr_test.groovy file in the jenkins/pipelines/ci/tikv/titan directory.

As for potential problems, it is not mentioned why the pipeline is being removed. If it is because it is no longer necessary, then there should be no issue. However, if it is removed because it is not working or causing issues, then this needs to be addressed.

If the pipeline is no longer necessary, it would be a good idea to add a brief explanation in the pull request description to clarify the rationale behind the change.

As for fixing suggestions, if the pipeline is being removed because it is not working or causing issues, it would be good to mention the steps taken to address the problem. Additionally, it would be helpful to provide any alternative solutions or pipelines that can be used to replace the removed pipeline.

Copy link

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign purelind for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo January 22, 2025 04:17
@ti-chi-bot ti-chi-bot bot added the size/S label Jan 22, 2025
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar v01dstar force-pushed the remove-titan-mac-job branch from cf145f1 to b5bd9da Compare January 22, 2025 04:26
Copy link

ti-chi-bot bot commented Jan 22, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and diff, the changes made are to remove the mac test pipeline from Titan. The PR removes the test_mac stage from the rocksdb_ghpr_test.groovy, rust_rocksdb_ghpr_test.groovy, and titan_ghpr_test.groovy files.

There are no potential problems identified in this PR. However, it is always a good practice to ensure that the changes made do not impact the functionality of other parts of the pipeline.

One suggestion to improve this PR is to add a brief description in the pull request description explaining the reason for removing the test_mac stage from the pipeline. This can help reviewers and future readers understand the purpose of this change.

@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Jan 22, 2025
@v01dstar v01dstar changed the title Remove mac test pipeline from Titan Remove mac test pipeline from storage repos Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant