Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tibuild): support commit to build #219

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

wuhuizuo
Copy link
Contributor

Usage:

/devbuild trigger --engine tekton -e enterprise tidb v8.5.0-dev commit/

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 31, 2024 09:40
Copy link

ti-chi-bot bot commented Dec 31, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Key changes in the pull request:

  • Added support for building from a specific commit using a new command devbuild trigger --engine tekton -e enterprise tidb v8.5.0-dev commit/<sha>
  • Created a new function getBranchForCommit to retrieve the branch name for a specific commit from Github
  • Added an implementation for GetBranchesForCommit in GitHubClient

Potential problems:

  • None that I can see at the moment

Fixing suggestions:

  • The code looks good, but it would be helpful to add some unit tests for the new functionality to ensure everything is working as expected.

@ti-chi-bot ti-chi-bot bot added the size/L label Dec 31, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 31, 2024
…mit`

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Dec 31, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of changes:

This pull request adds a new feature to the tibuild package which now supports building from a specific commit. It also adds a new function GetBranchesForCommit to the GHClient interface to retrieve the branches that contain the specified commit.

Potential problems:

  • The new feature may introduce additional complexity to the system and may require additional testing.
  • The GetBranchesForCommit function in gh_client.go may not work as expected because it uses a URL that does not appear to be documented in the GitHub API.

Fixing suggestions:

  • Consider adding additional tests to ensure that the new feature works as expected and does not introduce any regressions.
  • Consider using the GitHub API to retrieve the branches that contain the specified commit instead of using a URL that may not be documented in the API. This will ensure that the function works as expected and is less likely to break in the future.

@ti-chi-bot ti-chi-bot bot merged commit 7b83308 into main Dec 31, 2024
8 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/tibuild-support-commit branch December 31, 2024 10:18
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-ops that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant