Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/tasks): revert rustup mirrors #1378

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 17, 2024 05:35
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Dec 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, it seems the changes are made to revert the rustup mirrors. The changes include commenting out the environment variables which pointed to the Rust package manager mirrors for RUSTUP_DIST_SERVER and RUSTUP_UPDATE_ROOT.

There are no major issues found in the pull request as it is a simple revert. However, it is important to consider the reason behind the original changes and make sure this revert doesn't cause any further problems.

As a fixing suggestion, it would be a good idea to investigate why the mirrors were changed in the first place and whether or not they should be reverted back to the original values. If the original changes were made to resolve an issue, then it would be better to find an alternative solution rather than just reverting the changes.

Overall, this pull request seems to be straightforward and doesn't require much attention other than ensuring that the revert doesn't cause any issues.

@ti-chi-bot ti-chi-bot bot added the size/S label Dec 17, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit afb6854 into main Dec 17, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/revert-rustup-mirrors branch December 17, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant