Revert "fix: use BIC_OVERWRITE when cping static/ too"

This reverts commit d6b2e35.

bic

@@ -366,11 +366,7 @@ build_feed() {
 build_static() {
   [[ ! -d "${SRC_DIR}"/static ]] && return
   log "Building /static -> /"
-  # Archive by default
-  local args=(-a)
-  # And, don't clobber files unless explicitly disabled
-  [[ -z "${BIC_OVERWRITE:-}" ]] && args+=(-n)
-  cp "${args[@]}" "${SRC_DIR}"/static/. "${DEST_DIR}"
+  cp -a "${SRC_DIR}"/static/. "${DEST_DIR}"
 }
 
 build() {
@@ -380,7 +376,7 @@ build() {
   [[ "${SRC_DIR}" != "${__dir}" ]] && [[ -f "${SRC_DIR}"/.env ]] && src "${SRC_DIR}"/.env && log "Custom .env sourced"
   DEST_DIR="${SRC_DIR}/${BUILD_DIR:-build}"
   log "Using source directory: ${SRC_DIR}"
-  [[ -n "${BIC_OVERWRITE:-}" ]] && set +o noclobber && warn "Disabled overwrite protection"
+  [[ -n "${BIC_OVERWRITE:-}" ]] && set +o noclobber && log "Disabled 'noclobber' redirection overwrite protection"
 
   # File system: what's missing and do we need to bail?
   [[ -d "${SRC_DIR}"/pages && -f "${SRC_DIR}"/page.html  ]] || warn "pages/ + page.html for pages"

docs/index.md

@@ -66,7 +66,7 @@ generated site.
 
 ## Structure
 
-For a fully-featured example, view the [demo] source code: <https://github.com/Pinjasaur/bic-example>
+For a fully-featured example, view the demo source code: <https://github.com/Pinjasaur/bic-example>
 
 ```plaintext
 $ tree -F --dirsfirst
@@ -169,11 +169,10 @@ There is an order-of-operations for how files are built, as follows:
 - `feed.rss`
 - static e.g. `static/*` &rarr; `/`
 
-If you're not careful, it's possible you could overwrite an existing file e.g.
-`pages/test.md` and `posts/999-test.md` both map to `/test.html`. `bic` uses the
-Bash builtin `noclobber` e.g. `set -o noclobber` along with `--no-clobber` for
-`cp` to protect against these scenarios. This can be disabled by setting
-`BIC_OVERWRITE`. You've been warned.
+If you're not careful, it's possible you could overwrite an existing
+file e.g. `pages/test.md` and `posts/999-test.md` both map to `/test.html`. `bic`
+uses the Bash builtin `noclobber` e.g. `set -o noclobber` to help prevent these
+situations. This can be disabled by setting `BIC_OVERWRITE`.
 
 ## Showcase
 
@@ -182,7 +181,6 @@ Bash builtin `noclobber` e.g. `set -o noclobber` along with `--no-clobber` for
 - the demo: <https://demo.bic.sh/>
 - Mitch's blog: <https://fossen.dev/>
 - Evan's blog: <https://evanhstanton.github.io/>
-- you?
 
 ## Support
 

tests/test.bats

@@ -25,9 +25,8 @@
 
 @test "bic copies static/ correctly" {
   run ./bic tests/static
-  [[ "${status}" == 0 ]]
   [[ -f tests/static/build/humans.txt ]]
-  [[ -f tests/static/build/foo/bar/baz ]]
+  [[ "${status}" == 0 ]]
   rm -rf tests/static/build
   [[ ! -d tests/static/build ]]
 }
@@ -76,16 +75,6 @@
   [[ ! -d tests/overwrite/build ]]
 }
 
-@test "bic will not overwrite by default (static)" {
-  run ./bic tests/overwrite-static
-  [[ -f tests/overwrite-static/build/test.html ]]
-  [[ "${status}" != 0 ]] # errored out trying to overwrite test.html
-  run cat tests/overwrite-static/build/test.html
-  [[ "${lines[0]}" == "<p>post</p>" ]]
-  rm -rf tests/overwrite-static/build
-  [[ ! -d tests/overwrite-static/build ]]
-}
-
 @test "bic will overwrite if specified" {
   BIC_OVERWRITE=1 run ./bic tests/overwrite
   [[ -f tests/overwrite/build/test.html ]]
@@ -96,16 +85,6 @@
   [[ ! -d tests/overwrite/build ]]
 }
 
-@test "bic will overwrite if specified (static)" {
-  BIC_OVERWRITE=1 run ./bic tests/overwrite-static
-  [[ -f tests/overwrite-static/build/test.html ]]
-  [[ "${status}" == 0 ]] # didn't error out
-  run cat tests/overwrite-static/build/test.html
-  [[ "${lines[0]}" == "<p>static</p>" ]]
-  rm -rf tests/overwrite-static/build
-  [[ ! -d tests/overwrite-static/build ]]
-}
-
 @test "bic will honor a custom \$BUILD_DIR" {
   BUILD_DIR=_site run ./bic tests/index.html
   [[ -f tests/index.html/_site/index.html ]]