-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OS X ARM download url #795
base: master
Are you sure you want to change the base?
Conversation
WOW THANKS Piotr !!! UPDATE Could you please set our pipeline? Currently it is a bit involved, see https://github.com/Pix4D/ci-for-concourse and just the two sections "Setup" and "Developing the fork". Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Looks good. 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the ARM
Apple logo 💪
What happens if the fly ARM binary is not there ? |
That's the part why it's still in the draft. So There's no check whatsoever in the code, it just displays the download link as it's all hardcoded in the elm. I'm trying to figure out what kind of logic we could add so that it could be merged with upstream as well. In the ticket it was mentioned that we could write a logic around the embedded fly.. but I'm not sure that's the best. Another idea would be to maybe rely on some env configuration that can be passed (and if not, it just defaults to what was there currently). There's also the part about the logo - I'm happy that @odormond likes it, but it cannot be merged like so to the upstream 🙃 .. even though it's fun, we probably can't afford customizing original logos in something that is public. |
The download link would be broken but I guess that's actually true of any of the fly executable. |
Good point. Also, upstream might not want to accept the change anyway. I'm actually thinking that the proper solution is not to add a mac arm download link but to make |
The thing is, in our CI, thanks to Go, we just cross-build fly from Linux AMD64 to macOS ARM64 (sure we could change it...) |
Maybe we should try using: https://github.com/konoui/lipo |
AH! This is nice! |
@@ -13,6 +13,7 @@ all = | |||
List.map downloadUrl clis | |||
|> Expect.equal | |||
[ "/api/v1/cli?arch=amd64&platform=darwin" | |||
, "/api/v1/cli?arch=arm&platform=darwin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be arm64
fly-darwin-amd64.tgz fly-darwin-arm64.tgz fly-linux-amd64.tgz fly-windows-amd64.zip
Changes proposed by this PR
Addresses: https://pix4dbug.atlassian.net/browse/PCI-3893
Add OS X ARM option for download.
Notes to reviewer