Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(product): Added Kagi #174

Merged
merged 7 commits into from
Oct 28, 2023
Merged

feat(product): Added Kagi #174

merged 7 commits into from
Oct 28, 2023

Conversation

vkeerthivikram
Copy link
Contributor

Type of pull request: product addition

Provide more information about your pull request here. For help, see our contribution guide: http://privacyspy.org/contribute/

Added Kagi Product

doamatto
doamatto requested changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the quotes seem to be missing. I imagine that's likely in part for me taking a hot minute to get to this (which I apologise for), but if you can update this so that the quotes are matching what is on the privacy policy, I'd appreciate it a lot.

products/kagi.toml Outdated Show resolved Hide resolved
products/kagi.toml Outdated Show resolved Hide resolved
products/kagi.toml Outdated Show resolved Hide resolved
@doamatto doamatto self-assigned this Sep 23, 2023
@doamatto doamatto added product Related to a product on PrivacySpy size/S labels Sep 23, 2023
@vkeerthivikram
Copy link
Contributor Author

Hi @doamatto I have done the required changes. Please let me know if I missed anything. Thank you!!

doamatto
doamatto requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait again ; been very busy lately. These should be the last things needing a look-over. Thanks for all the work so far（＾_＾）

products/kagi.toml Outdated Show resolved Hide resolved
products/kagi.toml Show resolved Hide resolved
products/kagi.toml Show resolved Hide resolved
products/kagi.toml Outdated Show resolved Hide resolved
doamatto
doamatto requested changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loosely commented on it one-last time™, but it seems to just be a bit of whitespace issues and formatting issues. Once those get fixed, I'll merge it.

products/kagi.toml Outdated Show resolved Hide resolved
products/kagi.toml Outdated Show resolved Hide resolved
products/kagi.toml Outdated Show resolved Hide resolved
products/kagi.toml Outdated Show resolved Hide resolved
@doamatto doamatto merged commit 5b39225 into Politiwatch:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doamatto doamatto doamatto approved these changes

Assignees

@doamatto doamatto

Labels
product Related to a product on PrivacySpy size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkeerthivikram @doamatto