Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ente #189

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Added ente #189

merged 4 commits into from
Oct 2, 2024

Conversation

vkeerthivikram
Copy link
Contributor

Type of pull request: product addition

Related issues:
#185

Added ente following guidlines mentioned in https://privacyspy.org/contribute/

@doamatto doamatto linked an issue Oct 1, 2024 that may be closed by this pull request
Add ente - private cloud for your photos & videos #185
Closed
@doamatto doamatto added product Related to a product on PrivacySpy size/XS new contributor labels Oct 1, 2024
@doamatto doamatto self-assigned this Oct 1, 2024
doamatto
doamatto requested changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes to make. Could we also find a better icon ? It's very squished.

products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
products/ente.toml Outdated Show resolved Hide resolved
@doamatto
Copy link
Collaborator

doamatto commented Oct 1, 2024

On a somewhat related note, it looks like a lot of the notes were written by a chatbot or something of the like ? Politiwatch (afaik) doesn't bar contributions of that kind, but it would be interesting to know if that was the case. Apologies for the presumption if that's not the case

@vkeerthivikram
Copy link
Contributor Author

On a somewhat related note, it looks like a lot of the notes were written by a chatbot or something of the like ? Politiwatch (afaik) doesn't bar contributions of that kind, but it would be interesting to know if that was the case. Apologies for the presumption if that's not the case

Well, I did rewrite whatever notes I wrote, using an AI to make it look a bit professional. Apologize if that was an issue, I will put my original notes out there instead.

@vkeerthivikram
Copy link
Contributor Author

vkeerthivikram commented Oct 2, 2024 •
edited
Loading

Few changes to make. Could we also find a better icon ? It's very squished.

Regarding the icon, in the ente press kit, the icon is rectangular shaped, but it fails the tests, so I resized it to square shaped. Is it ok if I submit the rectangular shaped icon?

Edit: Found another more minimalistic icon from their github and added it

@doamatto
fix(product): changes to Ente
5d06a6c 
- Reduce potential bias in production description
- Reduced some blankspaces
- Added missing citation to `rubric.third-party-collection`
- Added missing citation to `rubric.security`
- Reworded note for `rubric.security`
@doamatto doamatto merged commit 106d0d7 into Politiwatch:master Oct 2, 2024
5 checks passed
@doamatto
Copy link
Collaborator

doamatto commented Oct 2, 2024

Looks all good now. Thanks ! ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doamatto doamatto doamatto approved these changes

Assignees

@doamatto doamatto

Labels
product Related to a product on PrivacySpy size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ente - private cloud for your photos & videos
2 participants
@vkeerthivikram @doamatto