Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SUMO Scheduler #201

Merged
merged 6 commits into from
Dec 24, 2024
Merged

Add SUMO Scheduler #201

merged 6 commits into from
Dec 24, 2024

Conversation

maximbelyakov
Copy link
Contributor

Type of pull request: product addition
Related issues: list the related issues here (if applicable)

Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a few things that need fixing, but a good start

[rubric.behavioral-marketing]
value = "yes-opt-out"
citations = [
"Yes, but you may opt-out. If you no longer wish to receive any marketing-related emails from us, you may opt-out via the unsubscribe link included in such emails."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be a direct citation and would only cover opt-out from newsletters, not targeted advertising

[rubric.security]
value = "yes"
citations = [
"Yes. For detailed information on our data security practices, please refer to our Privacy Policy. https://sumoscheduler.com/privacy-policy/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a citation. Can quote some of the things in the « How do we protect your information ? » section, but the score looks like it would end up being somewhat given it's the usual basic precautions most other policies mention

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I've seen the security policy a bit farther down, quoting from there and adding a note to check it would be ideal.

[rubric.third-party-collection]
value = "yes"
citations = [
"Yes, but only critical data (name, phone number, email). We collect and store content that you create, submit, post, upload, transmit, store or display in the process of using SUMO or our websites."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is first, not third party, collection. Should get rescored and a quote to match

[rubric.history]
value = "last-modified"
citations = [
"Yes"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citation should be of last modified in privacy policy (These updates will take effect on May 25, 2018.)

[rubric.data-deletion]
value = "yes-contact"
citations = [
"Yes, by contacting someone. If your account is managed by a System Administrator, that administrator may have control with regards to how your account information is retained and deleted. However, customers may also contact us at support@sumoscheduler.com to request the complete deletion of your personal data. We will respond to your request within 30 days."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove « Yes, by contacting someone. » since that's not a quote on the page

[rubric.data-collection-reasoning]
value = "yes"
citations = [
"We collect and store content that you create, submit, post, upload, transmit, store or display in the process of using SUMO or our websites."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be ideal to have the full list of collection purposes

[rubric.noncritical-purposes]
value = "opt-out-some"
citations = [
"Yes, but you may opt-out. If you no longer wish to receive any marketing-related emails from us, you may opt-out via the unsubscribe link included in such emails."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a direct citation. May be a good idea to add a note mentioning that you're only able to opt-out of e-mails

[rubric.law-enforcement]
value = "strict"
citations = [
"Only when required by a court order or subpoena. We may disclose your information, including your personal data, to a third party if (a) we believe that disclosure is reasonably necessary to comply with any applicable laws and regulation or governmental request by court order or subpoena."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First sentence isn't a citation and should be removed

[rubric.revision-notify]
value = "yes"
citations = [
"No. As per the policy, SUMO reserves the right to amend our Privacy Policy at any time to reflect changes in the law, our data collection and use practices, and the features of our Services. If we decide to change our privacy policy, we will post those changes on this page. https://sumoscheduler.com/privacy-policy/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the privacy policy mentions that an e-mail will be sent out — should be updated to reflect. Score is OK

[rubric.list-collected]
value = "generally"
citations = [
"Yes, but only critical data (name, phone number, email). We collect and store content that you create, submit, post, upload, transmit, store or display in the process of using SUMO or our websites."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a citation(s) of the full list of data collected

@maximbelyakov
Copy link
Contributor Author

@doamatto Could you check please?

Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume from your GH profile you work here and the quotes might be from an upcoming change. Once it's reflected there, I'll give it another once over to make sure everything's solid in that regard. Until then, I can't merge it since most of the citations don't exist in the policy.

products/sumo-scheduler.toml Show resolved Hide resolved
products/sumo-scheduler.toml Outdated Show resolved Hide resolved
products/sumo-scheduler.toml Outdated Show resolved Hide resolved
products/sumo-scheduler.toml Outdated Show resolved Hide resolved
products/sumo-scheduler.toml Show resolved Hide resolved
products/sumo-scheduler.toml Outdated Show resolved Hide resolved
products/sumo-scheduler.toml Outdated Show resolved Hide resolved
@maximbelyakov
Copy link
Contributor Author

@doamatto Hello!

Could you review the changes please?

@maximbelyakov
Copy link
Contributor Author

maximbelyakov commented Dec 13, 2024

@doamatto Do you need any changes from me?

@maximbelyakov
Copy link
Contributor Author

@bcbee @loviuz @milesmcc

Sorry, can you check it please guys?

Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delays — I had more pressing matter to attend to recently. This should be everything, but I'll polish it and get this MR merged in a titbit. Thank you for your work

products/sumo-scheduler.toml Show resolved Hide resolved
products/sumo-scheduler.toml Show resolved Hide resolved
- Add citation and update score for rubric.security
- Remove missing citation, add note, update score for rubric.third-party-collection
- Add real citation for rubric.data-deletion
- Move link for rubric.data-breaches
- Update score for and cite rubric.third-party-access
- Add real citation for rubric.data-collection-reasoning
- Remove superfluous note for rubric.noncritical-purposes
- Update score for rubric.law-enforcement
- Add real citation for rubric.list-collected
- Add real citation for rubric.revision-notify
@doamatto doamatto self-requested a review December 24, 2024 23:27
@doamatto doamatto dismissed their stale review December 24, 2024 23:27

Resolved by self

@doamatto doamatto merged commit a62897d into Politiwatch:master Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants