-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show event ticks in player modal #27819
base: master
Are you sure you want to change the base?
Conversation
const { closeSessionPlayer } = useActions(sessionPlayerModalLogic()) | ||
|
||
// activeSessionRecording?.matching_events should always be a single element array | ||
// but, we're filtering and using flatMap just in case | ||
const eventUUIDs = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm surprised this is safe... but i don't have enough recordings locally to test
there are two matching modes iirc
- simple events -> done locally
- events with filters -> done as a follow-up query
could this path be necessary for that second type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so long as the matching events still work if you filter e.g. pageview by current url on the home page / playlist page then i'm happy
Problem
There was no way to highlight
$exception
events when viewing recordings from the error tracking pageChanges
matching_events
as it didn't seem to be used anywhere or could be replaced withmatchingEventsMatchType
openSessionPlayer
to take thematchingEventsMatchType
argumenteventName
property to the HogQLXRecordingButton
which creates a 'name' match type on theViewRecordingButton
component. Cannot directly pass thematchingEventsMatchType
prop because HogQLX does not support complex object arguments