feat: only send one digest email per org with all team info #27851
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR consolidates multiple team digest emails into a single organization-wide email, improving the notification experience for organizations with multiple teams while maintaining proper access controls.
- Introduced new
OrgDigestReportandTeamDigestReportdata classes inreport_utils.pyto structure organization-level reporting - Added user-specific report filtering in
periodic_digest.pyto ensure users only see data from teams they have access to and notifications enabled for - Implemented organization-level idempotency using
MessagingRecordwith campaign keys that include period length - Added comprehensive test coverage in
test_periodic_digest.pyfor multi-team scenarios, access controls, and notification preferences - Potential memory concern with upfront data loading for large organizations, as noted in PR description
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| teams: dict[str, TeamDigestReport] # team_id -> TeamDigestReport | ||
| total_digest_items_with_data: int |
There was a problem hiding this comment.
logic: teams dict uses string keys but stores integer team_ids. This mixed typing could cause issues. Consider using int keys consistently
| team_id=int(next(iter(user_report.teams.keys()))), # Use first team for compatibility | ||
| organization_id=org_id, |
There was a problem hiding this comment.
logic: using first team arbitrarily could cause issues if that team has different settings or configuration than other teams in the org - consider using a more deterministic selection method
| user_teams[user.id] = set() | ||
| user_notifications[user.id] = set() |
There was a problem hiding this comment.
style: initializing empty sets for both user_teams and user_notifications could be moved outside the team loop to avoid redundant operations
|
Going to remove my review and subscribe instead. I can follow the summary, but actually approving code like this is a bit of a stretch for me! |
| # Check if we've already sent this digest | ||
| period_str = period_end.strftime("%Y-%m-%d") | ||
| days = (period_end - period_start).days | ||
| campaign_key = f"periodic_digest_{period_str}_{days}d" |
There was a problem hiding this comment.
Not sure if we want to be careful about allowing end_date=None AND begin_date=some_date as args for this, as it'll determine this key differently based on the day it runs, but that might be intentional?
Problem
For orgs with multiple teams, sending an email per team was overwhelming.
Changes
I'm somewhat concerned about memory utilization with this approach because we're now keeping a lot more in memory than we were before. So any suggestions there are welcome - otherwise we will just see how it goes.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Should..
How did you test this code?
Updated tests