rec: Backport 15010 to rec 5.2.x: fix protobufServer(.. {taggedOnly=true}) logic for cache-returned responses #10727
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --- | |
| name: 'Build and test everything' | |
| on: | |
| push: | |
| pull_request: | |
| workflow_call: | |
| inputs: | |
| branch-name: | |
| description: 'Checkout to a specific branch' | |
| required: true | |
| default: '' | |
| type: string | |
| runner-docker-image-name: | |
| description: 'Image name to be used for running all jobs' | |
| required: false | |
| default: '' | |
| type: string | |
| schedule: | |
| - cron: '0 22 * * 3' | |
| permissions: # least privileges, see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions | |
| contents: read | |
| env: | |
| COMPILER: clang | |
| CLANG_VERSION: '13' | |
| # github.workspace variable points to the Runner home folder. Container home folder defined below. | |
| REPO_HOME: '/__w/${{ github.event.repository.name }}/${{ github.event.repository.name }}' | |
| BUILDER_VERSION: '0.0.0-git1' | |
| COVERAGE: ${{ github.repository == 'PowerDNS/pdns' && 'yes' || 'no' }} | |
| LLVM_PROFILE_FILE: "/tmp/code-%p.profraw" | |
| OPTIMIZATIONS: yes | |
| jobs: | |
| get-runner-container-image: | |
| name: generate docker runner image name | |
| runs-on: ubuntu-22.04 | |
| outputs: | |
| id: ${{ steps.get-runner-image.outputs.image-id }} | |
| tag: ${{ steps.get-runner-image.outputs.tag }} | |
| env: | |
| DEFAULT_RUNNER_DOCKER_IMAGE: base-pdns-ci-image/debian-12-pdns-base | |
| DEFAULT_IMAGE_TAG: master # update when backporting, e.g. auth-4.9.x | |
| steps: | |
| - id: get-runner-image | |
| run: | | |
| echo "image-id=ghcr.io/powerdns/${{ inputs.runner-docker-image-name || env.DEFAULT_RUNNER_DOCKER_IMAGE }}" >> "$GITHUB_OUTPUT" | |
| echo "tag=${{ env.DEFAULT_IMAGE_TAG }}" >> "$GITHUB_OUTPUT" | |
| build-recursor: | |
| name: build recursor | |
| if: ${{ !github.event.schedule || vars.SCHEDULED_JOBS_BUILD_AND_TEST_ALL }} | |
| runs-on: ubuntu-22.04 | |
| needs: get-runner-container-image | |
| strategy: | |
| matrix: | |
| sanitizers: [ubsan+asan, tsan] | |
| features: [least, full] | |
| exclude: | |
| - sanitizers: tsan | |
| features: least | |
| container: | |
| image: "${{ needs.get-runner-container-image.outputs.id }}:${{ needs.get-runner-container-image.outputs.tag }}" | |
| env: | |
| SANITIZERS: ${{ matrix.sanitizers }} | |
| UBSAN_OPTIONS: "print_stacktrace=1:halt_on_error=1:suppressions=${{ env.REPO_HOME }}/build-scripts/UBSan.supp" | |
| UNIT_TESTS: yes | |
| options: --sysctl net.ipv6.conf.all.disable_ipv6=0 | |
| defaults: | |
| run: | |
| working-directory: ./pdns/recursordist/pdns-recursor-${{ env.BUILDER_VERSION }} | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 5 | |
| submodules: recursive | |
| ref: ${{ inputs.branch-name }} | |
| - name: get timestamp for cache | |
| id: get-stamp | |
| run: | | |
| echo "stamp=$(/bin/date +%s)" >> "$GITHUB_OUTPUT" | |
| shell: bash | |
| working-directory: . | |
| - run: mkdir -p ~/.ccache | |
| working-directory: . | |
| - name: let GitHub cache our ccache data | |
| uses: actions/cache@v4 | |
| with: | |
| path: ~/.ccache | |
| key: recursor-${{ matrix.features }}-${{ matrix.sanitizers }}-ccache-${{ steps.get-stamp.outputs.stamp }} | |
| restore-keys: recursor-${{ matrix.features }}-${{ matrix.sanitizers }}-ccache- | |
| - run: inv ci-install-rust ${{ env.REPO_HOME }} | |
| working-directory: ./pdns/recursordist/ | |
| - run: inv ci-autoconf | |
| working-directory: ./pdns/recursordist/ | |
| - run: inv ci-rec-configure ${{ matrix.features }} | |
| working-directory: ./pdns/recursordist/ | |
| - run: inv ci-make-distdir | |
| working-directory: ./pdns/recursordist/ | |
| - run: inv ci-rec-configure ${{ matrix.features }} | |
| - run: inv ci-rec-make-bear | |
| - run: inv ci-rec-run-unit-tests | |
| - run: inv generate-coverage-info ./testrunner $GITHUB_WORKSPACE | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| - name: Coveralls Parallel rec unit | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| uses: coverallsapp/github-action@v2 | |
| with: | |
| flag-name: rec-unit-${{ matrix.features }}-${{ matrix.sanitizers }} | |
| path-to-lcov: $GITHUB_WORKSPACE/coverage.lcov | |
| parallel: true | |
| allow-empty: true | |
| fail-on-error: false | |
| - run: inv ci-make-install | |
| - run: ccache -s | |
| - run: echo "normalized-branch-name=${{ inputs.branch-name || github.ref_name }}" | tr "/" "-" >> "$GITHUB_ENV" | |
| - name: Store the binaries | |
| uses: actions/upload-artifact@v4 # this takes 30 seconds, maybe we want to tar | |
| with: | |
| name: pdns-recursor-${{ matrix.features }}-${{ matrix.sanitizers }}-${{ env.normalized-branch-name }} | |
| path: /opt/pdns-recursor | |
| retention-days: 1 | |
| test-recursor-api: | |
| needs: | |
| - build-recursor | |
| - get-runner-container-image | |
| runs-on: ubuntu-22.04 | |
| strategy: | |
| matrix: | |
| sanitizers: [ubsan+asan, tsan] | |
| dist_name: [debian] | |
| pdns_repo_version: ['48'] | |
| container: | |
| image: "${{ needs.get-runner-container-image.outputs.id }}:${{ needs.get-runner-container-image.outputs.tag }}" | |
| env: | |
| UBSAN_OPTIONS: "print_stacktrace=1:halt_on_error=1:suppressions=${{ env.REPO_HOME }}/build-scripts/UBSan.supp" | |
| ASAN_OPTIONS: detect_leaks=0 | |
| TSAN_OPTIONS: "halt_on_error=1:suppressions=${{ env.REPO_HOME }}/pdns/recursordist/recursor-tsan.supp" | |
| options: --sysctl net.ipv6.conf.all.disable_ipv6=0 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 5 | |
| submodules: recursive | |
| ref: ${{ inputs.branch-name }} | |
| - run: echo "normalized-branch-name=${{ inputs.branch-name || github.ref_name }}" | tr "/" "-" >> "$GITHUB_ENV" | |
| - name: Fetch the binaries | |
| uses: actions/download-artifact@v4 | |
| with: | |
| name: pdns-recursor-full-${{ matrix.sanitizers }}-${{ env.normalized-branch-name }} | |
| path: /opt/pdns-recursor | |
| - run: inv apt-fresh | |
| - run: inv add-auth-repo ${{ matrix.dist_name }} $(. /etc/os-release && echo $VERSION_CODENAME) ${{ matrix.pdns_repo_version }} | |
| - run: inv install-clang-runtime | |
| - run: inv install-rec-test-deps | |
| - run: inv test-api recursor | |
| - run: inv generate-coverage-info /opt/pdns-recursor/sbin/pdns_recursor $GITHUB_WORKSPACE | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| - name: Coveralls Parallel recursor API | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| uses: coverallsapp/github-action@v2 | |
| with: | |
| flag-name: rec-api-full-${{ matrix.sanitizers }} | |
| path-to-lcov: $GITHUB_WORKSPACE/coverage.lcov | |
| parallel: true | |
| allow-empty: true | |
| fail-on-error: false | |
| test-recursor-regression: | |
| needs: | |
| - build-recursor | |
| - get-runner-container-image | |
| runs-on: ubuntu-22.04 | |
| strategy: | |
| matrix: | |
| sanitizers: [ubsan+asan, tsan] | |
| dist_name: [debian] | |
| pdns_repo_version: ['48'] | |
| container: | |
| image: "${{ needs.get-runner-container-image.outputs.id }}:${{ needs.get-runner-container-image.outputs.tag }}" | |
| env: | |
| UBSAN_OPTIONS: 'print_stacktrace=1:halt_on_error=1:suppressions=${{ env.REPO_HOME }}/build-scripts/UBSan.supp' | |
| ASAN_OPTIONS: "" | |
| LSAN_OPTIONS: "suppressions=${{ env.REPO_HOME }}/pdns/recursordist/recursor-lsan.supp" | |
| TSAN_OPTIONS: "halt_on_error=1:suppressions=${{ env.REPO_HOME }}/pdns/recursordist/recursor-tsan.supp" | |
| options: --sysctl net.ipv6.conf.all.disable_ipv6=0 | |
| steps: | |
| # - uses: PowerDNS/pdns/set-ubuntu-mirror@meta | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 5 | |
| submodules: recursive | |
| ref: ${{ inputs.branch-name }} | |
| - run: echo "normalized-branch-name=${{ inputs.branch-name || github.ref_name }}" | tr "/" "-" >> "$GITHUB_ENV" | |
| - name: Fetch the binaries | |
| uses: actions/download-artifact@v4 | |
| with: | |
| name: pdns-recursor-full-${{ matrix.sanitizers }}-${{ env.normalized-branch-name }} | |
| path: /opt/pdns-recursor | |
| - run: inv apt-fresh | |
| - run: inv add-auth-repo ${{ matrix.dist_name }} $(. /etc/os-release && echo $VERSION_CODENAME) ${{ matrix.pdns_repo_version }} | |
| - run: inv install-clang-runtime | |
| - run: inv install-rec-test-deps | |
| - run: inv test-regression-recursor | |
| - run: inv generate-coverage-info /opt/pdns-recursor/sbin/pdns_recursor $GITHUB_WORKSPACE | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| - name: Coveralls Parallel recursor regression | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| uses: coverallsapp/github-action@v2 | |
| with: | |
| flag-name: rec-regression-full-${{ matrix.sanitizers }} | |
| path-to-lcov: $GITHUB_WORKSPACE/coverage.lcov | |
| parallel: true | |
| allow-empty: true | |
| fail-on-error: false | |
| test-recursor-bulk: | |
| name: 'test rec *mini* bulk' | |
| needs: | |
| - build-recursor | |
| - get-runner-container-image | |
| runs-on: ubuntu-22.04 | |
| strategy: | |
| matrix: | |
| sanitizers: [ubsan+asan, tsan] | |
| threads: [1, 2, 3, 4, 8] | |
| mthreads: [2048] | |
| shards: [1, 2, 1024] | |
| container: | |
| image: "${{ needs.get-runner-container-image.outputs.id }}:${{ needs.get-runner-container-image.outputs.tag }}" | |
| env: | |
| UBSAN_OPTIONS: 'print_stacktrace=1:halt_on_error=1:suppressions=${{ env.REPO_HOME }}/build-scripts/UBSan.supp' | |
| ASAN_OPTIONS: detect_leaks=0 | |
| TSAN_OPTIONS: "halt_on_error=1:suppressions=${{ env.REPO_HOME }}/pdns/recursordist/recursor-tsan.supp" | |
| options: --sysctl net.ipv6.conf.all.disable_ipv6=0 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 5 | |
| submodules: recursive | |
| ref: ${{ inputs.branch-name }} | |
| - run: echo "normalized-branch-name=${{ inputs.branch-name || github.ref_name }}" | tr "/" "-" >> "$GITHUB_ENV" | |
| - name: Fetch the binaries | |
| uses: actions/download-artifact@v4 | |
| with: | |
| name: pdns-recursor-full-${{ matrix.sanitizers }}-${{ env.normalized-branch-name }} | |
| path: /opt/pdns-recursor | |
| - run: inv install-clang-runtime | |
| - run: inv install-rec-bulk-deps | |
| - run: inv test-bulk-recursor ${{ matrix.threads }} ${{ matrix.mthreads }} ${{ matrix.shards }} | |
| - run: inv generate-coverage-info /opt/pdns-recursor/sbin/pdns_recursor $GITHUB_WORKSPACE | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| - name: Coveralls Parallel recursor bulk | |
| if: ${{ env.COVERAGE == 'yes' && matrix.sanitizers != 'tsan' }} | |
| uses: coverallsapp/github-action@v2 | |
| with: | |
| flag-name: rec-regression-bulk-full-${{ matrix.sanitizers }} | |
| path-to-lcov: $GITHUB_WORKSPACE/coverage.lcov | |
| parallel: true | |
| allow-empty: true | |
| fail-on-error: false | |
| collect: | |
| needs: | |
| - build-recursor | |
| - test-recursor-api | |
| - test-recursor-regression | |
| - test-recursor-bulk | |
| if: success() || failure() | |
| runs-on: ubuntu-22.04 | |
| steps: | |
| - name: Coveralls Parallel Finished | |
| if: ${{ env.COVERAGE == 'yes' }} | |
| uses: coverallsapp/github-action@v2 | |
| with: | |
| parallel-finished: true | |
| fail-on-error: false | |
| - name: Install jq and jc | |
| run: "sudo apt-get update && sudo apt-get install jq jc" | |
| - name: Fail job if any of the previous jobs failed | |
| run: "for i in `echo '${{ toJSON(needs) }}' | jq -r '.[].result'`; do if [[ $i == 'failure' ]]; then echo '${{ toJSON(needs) }}'; exit 1; fi; done;" | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 5 | |
| submodules: recursive | |
| ref: ${{ inputs.branch-name }} | |
| - name: Get list of jobs in the workflow | |
| run: "cat .github/workflows/build-and-test-all.yml | jc --yaml | jq -rS '.[].jobs | keys | .[]' | grep -vE 'collect|get-runner-container-image' | tee /tmp/workflow-jobs-list.yml" | |
| - name: Get list of prerequisite jobs | |
| run: "echo '${{ toJSON(needs) }}' | jq -rS 'keys | .[]' | tee /tmp/workflow-needs-list.yml" | |
| - name: Fail if there is a job missing on the needs list | |
| run: "if ! diff -q /tmp/workflow-jobs-list.yml /tmp/workflow-needs-list.yml; then exit 1; fi" | |
| # FIXME: if we can make upload/download-artifact fasts, running unit tests outside of build can let regression tests start earlier |