clang-tidy: use std::min/max #14954
Open
clang-tidy: use std::min/max #14954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12403993595Details
💛 - Coveralls |
miodvallat
reviewed
Dec 11, 2024
pdns/lua-record.cc
Outdated
| if (port > std::numeric_limits<uint16_t>::max()) { | ||
| port = std::numeric_limits<uint16_t>::max(); | ||
| } | ||
| lua.writeFunction("ifportup", [](int port, const boost::variant<iplist_t, ipunitlist_t>& ips, const boost::optional<std::unordered_map<string, string>>& options) { |
There was a problem hiding this comment.
Why did you change the signature of the lambda here? (passing options by reference)
This is not related to the algorithmic changes.
There was a problem hiding this comment.
Looked like a mistake
There was a problem hiding this comment.
I'm afraid it actually breaks the feature because the options parameter is no longer optional.
rgacogne
requested changes
Dec 12, 2024
pdns/lua-record.cc
Outdated
| if (port > std::numeric_limits<uint16_t>::max()) { | ||
| port = std::numeric_limits<uint16_t>::max(); | ||
| } | ||
| lua.writeFunction("ifportup", [](int port, const boost::variant<iplist_t, ipunitlist_t>& ips, const boost::optional<std::unordered_map<string, string>>& options) { |
There was a problem hiding this comment.
I'm afraid it actually breaks the feature because the options parameter is no longer optional.
|
sounds broken. |
rgacogne
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
The changes look OK to me, and we can ignore clang-tidy's warning which is incorrect. I wouldn't mind a second review from either @omoerbeek or @Habbie before merging this.
miodvallat
reviewed
Dec 13, 2024
neheb
force-pushed
the
mm
branch
2 times, most recently
from
1125d42 to
eb172b3
Compare
Found with readability-use-std-min-max Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
miodvallat
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with readability-use-std-min-max
I have: