-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: if the full CNAME chain leading to the answer is cached, indicate that #14973
rec: if the full CNAME chain leading to the answer is cached, indicate that #14973
Conversation
…e that Alternative approach to PowerDNS#14918
Pull Request Test Coverage Report for Build 12370453034Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, I would love a test :)
Co-authored-by: Remi Gacogne <github@coredump.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution looks better than mine.
For example, if there are multiple layers of cname cache for the domain name in the cache, and the last cname has an A record or the last cname has no record cache, if the AAAA type is requested at this time, it looks like in step 0 cache lookup, only the AAAA type of the last cname is resolved through the network, and the others will be returned through the cache. You can test it.
73e5d93
to
f533aca
Compare
Alternative approach to PR #14918 from @zjs604381586.
I find the approach to be more clear. Once we agree which one is best, I'll add a unit test.
Short description
Checklist
I have: