Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: make quit-nicely wait on actual quit and start using it for stopping by systemd #14976

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

omoerbeek
Copy link
Member

Short description

Undecided if this should make rec-5.2.0 also not battle tested, hence Draft.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek marked this pull request as draft December 16, 2024 14:44
@omoerbeek omoerbeek force-pushed the rec-quit-nicely-sync branch from 34774c4 to d062894 Compare December 16, 2024 14:53
@coveralls
Copy link

coveralls commented Dec 16, 2024

Pull Request Test Coverage Report for Build 12394202504

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 31 (90.32%) changed or added relevant lines in 4 files are covered.
  • 53 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.08%) to 64.901%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/rec-main.cc 15 16 93.75%
pdns/recursordist/rec_channel.cc 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.4%
pdns/dnsdistdist/dnsdist.hh 1 84.24%
pdns/misc.cc 1 64.74%
pdns/pollmplexer.cc 1 83.66%
pdns/validate.cc 1 68.61%
pdns/recursordist/syncres.cc 2 80.22%
modules/godbcbackend/sodbc.cc 2 70.8%
pdns/iputils.cc 3 55.91%
pdns/recursordist/test-syncres_cc2.cc 3 89.03%
pdns/opensslsigners.cc 3 61.41%
Totals Coverage Status
Change from base Build 12373746857: 0.08%
Covered Lines: 126248
Relevant Lines: 163789

💛 - Coveralls

Co-authored-by: Miod Vallat <miod.vallat@open-xchange.com>
@omoerbeek
Copy link
Member Author

A reggression test fails with: msg="Fatal" error="Unable to receive return status over control channel: Success" subsystem="config" level="0" prio="Error" ts="1734362335.838" Investigating.

@omoerbeek omoerbeek force-pushed the rec-quit-nicely-sync branch 2 times, most recently from 246288a to ac2d1ed Compare December 18, 2024 08:52
@omoerbeek omoerbeek force-pushed the rec-quit-nicely-sync branch from ac2d1ed to 08fbac7 Compare December 18, 2024 09:31
@omoerbeek omoerbeek changed the title rec: make quit-nicely wait on actual quit rec: make quit-nicely wait on actual quit and start using it for stopping by systemd Dec 18, 2024
@omoerbeek
Copy link
Member Author

While this seems to work, I do not think it is wise to add this to the 5.2 release cycle which is almost done. So moving this to 5.3.0. Running rec_control quit-nicely will call the stop hook and leave the unit is a stopped state.

@omoerbeek omoerbeek added this to the rec-5.3.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants