-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: run daily bulk test on ubicloud #15021
Conversation
Pull Request Test Coverage Report for Build 12709832768Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Test run: https://github.com/romeroalx/pdns/actions/runs/12674038149
Do you think this job could be included in the already existing workflow misc-dailies instead of a new one? I do not have a strong opinion about this. Maybe it is because the name is somehow similar. A new workflow as is done in this PR is also fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit that I can live with. Alexis' comment about misc-dailies makes sense, if only because our total list of workflows is getting quite big.
.github/workflows/test-daily.yml
Outdated
|
||
jobs: | ||
run-rec-bulk-test: | ||
if: ${{ vars.REC_BULKTEST_USE_UBICLOUD == '1' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit misnamed. if it is set to 0, the test does not run at all, instead of running on "not ubicloud"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename and move the code to misc-dailies, although we run the risk this becoming a hotchpot of unrelated workflows that only have in common that they are run daily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no, I just meant the var name. As for moving, I'm torn between "we have too many workflows" and "workflows are a good tool for organising things in a way that makes sense". Thinking about it, I realise another important feature of workflows is that they can be disabled/enabled from the UI. So keeping things a bit separate makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you consider a good name for the var? I'm having trouble naming things...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UBICLOUD_DAILY_REC_BULKTEST?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've left the job in the misc-daily workflow. I prefer to do reorg of that some other time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
BTW, from the conversation in the PR I thought the variable was going to be renamed: "if it is set to 0, the test does not run at all, instead of running on "not ubicloud""
Ah, my interpretation was Habbie was talking about the job name.... |
Short description
Get the package from our repo (master branch).
We run both an IPv4 only test and a IPV6 enabled one.
Checklist
I have: