pdnsutil add-zone-key: more checks #15025
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Old issues #1304 and #2855 describe situations where
pdnsutil add-zone-key
failed yet did not report failure.I believe the current state of the code will correctly report failure, but it does not hurt to be more careful in
pdnsutil
. The changes in this PR achieve two things:pdnsutil add-zone-key
will exit with non-zero status if attempting to get the key ID from the backend failed (for we can not be sure a key had been added in this case).The first two commits are purely janitorial cleanup; the important change is found in the third commit. Commit-by-commit review recommended.
Checklist
I have: