Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: fix doh3-less compile #15028

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

omoerbeek
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek force-pushed the dnsdist-fix-build-no-doh3 branch from 7bfb9ed to 988af70 Compare January 10, 2025 10:22
@coveralls
Copy link

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 12708358563

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 42 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-7.2%) to 64.941%

Files with Coverage Reduction New Missed Lines %
pdns/tcpiohandler.cc 2 68.18%
pdns/misc.hh 3 87.62%
pdns/dnsdistdist/dnsdist-carbon.cc 3 64.8%
pdns/recursordist/syncres.cc 3 80.3%
pdns/dnsdistdist/dnsdist-lbpolicies.cc 4 69.83%
pdns/shuffle.cc 4 53.93%
pdns/recursordist/rec-tcpout.cc 5 50.79%
pdns/signingpipe.cc 5 86.06%
pdns/recursordist/test-syncres_cc1.cc 13 89.41%
Totals Coverage Status
Change from base Build 12707568580: -7.2%
Covered Lines: 126305
Relevant Lines: 163714

💛 - Coveralls

@omoerbeek omoerbeek force-pushed the dnsdist-fix-build-no-doh3 branch from 988af70 to 5d7ebcd Compare January 10, 2025 11:07
@omoerbeek omoerbeek merged commit 3c5eafa into PowerDNS:master Jan 10, 2025
81 checks passed
@omoerbeek omoerbeek deleted the dnsdist-fix-build-no-doh3 branch January 10, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants