Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add the ability to set custom HTTP responses over DoH3 #15029

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rgacogne
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

pdns/dnsdistdist/doh3.cc Outdated Show resolved Hide resolved
pdns/dnsdistdist/doh3.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking gud.

@coveralls
Copy link

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 12711285724

Details

  • 81 of 83 (97.59%) changed or added relevant lines in 4 files are covered.
  • 57 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.941%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-lua-actions.cc 20 22 90.91%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/aggressive_nsec.cc 2 66.02%
pdns/dnsdistdist/dnsdist.cc 2 68.98%
pdns/misc.hh 3 87.62%
pdns/remote_logger.cc 3 53.81%
pdns/misc.cc 3 65.02%
pdns/iputils.cc 3 55.91%
modules/godbcbackend/sodbc.cc 4 70.8%
pdns/recursordist/syncres.cc 5 80.09%
pdns/rcpgenerator.cc 5 90.46%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.87%
Totals Coverage Status
Change from base Build 12710659725: 0.02%
Covered Lines: 126350
Relevant Lines: 163744

💛 - Coveralls

@rgacogne rgacogne force-pushed the ddist-doh3-set-http-response branch from 83fcd3a to 98151bd Compare January 10, 2025 13:40
@rgacogne
Copy link
Member Author

Rebased to fix a conflict.

@rgacogne rgacogne force-pushed the ddist-doh3-set-http-response branch from 98151bd to 7285f2f Compare January 10, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants