Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions - build-docker-images.yaml: allow testing image building without credentials #15073

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

romeroalx
Copy link
Member

Short description

This PR allows not setting credentials when setting push: false. Useful for testing images.

Removes warning: LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 39)

Test: https://github.com/romeroalx/pdns/actions/runs/12885369941

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@romeroalx romeroalx added github_actions Pull requests that update GitHub Actions code ci labels Jan 21, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12890144520

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.001%) to 64.696%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.44%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/dnsdistdist/dnsdist-carbon.cc 3 64.27%
pdns/iputils.cc 3 56.07%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/recursordist/test-syncres_cc1.cc 8 89.64%
pdns/recursordist/rec-tcp.cc 10 66.07%
ext/json11/json11.cpp 12 62.72%
Totals Coverage Status
Change from base Build 12884379895: -0.001%
Covered Lines: 127797
Relevant Lines: 166433

💛 - Coveralls

@romeroalx romeroalx merged commit 3de14d7 into PowerDNS:master Jan 22, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants