Skip to content

Commit

Permalink
Update packages with a VS Code engine bump to 1.96
Browse files Browse the repository at this point in the history
With new string casts to quiet new warnings.
  • Loading branch information
andyleejordan committed Jan 15, 2025
1 parent 0c5f2f8 commit 0d214ae
Show file tree
Hide file tree
Showing 7 changed files with 259 additions and 281 deletions.
7 changes: 3 additions & 4 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ dictates which version of Node.js the extension is eventually run with. This
lets us finally update our `@types/node` development dependency to match, our
developer machines if necessary, and the CI and OneBranch pipeline tasks.

[`vscodeVersion`]: https://github.com/microsoft/azuredatastudio/blob/4970733324ef8254b7c22a5dc55af7f8a1dea93f/product.json#L50
[`electron`]: https://github.com/microsoft/vscode/blob/384ff7382de624fb94dbaf6da11977bba1ecd427/package.json#L159
[Electron]: https://www.electronjs.org/blog/electron-30-0
[`electron`]: https://github.com/microsoft/vscode/blob/138f619c86f1199955d53b4166bef66ef252935c/package.json#L156
[Electron]: https://releases.electronjs.org/release/v32.2.6
[Node.js]: https://nodejs.org/en/download/package-manager

### Building the Code
Expand All @@ -65,7 +64,7 @@ To debug the extension use one of the provided `Launch Extension` debug configur

All three templates use pre-launch tasks to build the code, and support automatic restart of the extension host on changes to the Extension source code. [Hot Reload](https://devblogs.microsoft.com/dotnet/introducing-net-hot-reload/) is also enabled for PowerShell Editor Services.

> [!WARNING]
> [!WARNING]
> There is a current limitation that, if you restart the extension/extension host or it is restarted due to a extension code change, the editor services attachment will be disconnected due to the PSES terminal being terminated, and you will either need to restart the debug session completely, or do a manual build of PSES and run the `Attach to Editor Services` debug launch manually.
Try the `powershell.developer.editorServicesWaitForDebugger` setting to ensure that you are fully attached before the extension startup process continues.
Expand Down
Loading

0 comments on commit 0d214ae

Please sign in to comment.