events.py #365
Open
events.py #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Innovatorcloudy
commented
Oct 25, 2024
Innovatorcloudy
commented
- Simplified conditional checks and utilized get for dictionary access
- Added logging statements to key points for better traceability.
- Improved the structure of message transformations, emphasizing clarity and maintainability
|
@jlowin Sir can you review and merge it |
jlowin
requested changes
Oct 29, 2024
There was a problem hiding this comment.
There are some changes here that are good like class docstrings, some that I think are unnecessary like debug logs for events that are already debug-logged elsewhere, and some that are contrary to how this codebase works, like replacing private validators with public ones and importing List from typing. I would accept the first type but the latter add to cognitive burden.
made the changes suggested.
jlowin
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.