Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: NONE to NO_CACHE #16650

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Proposal: NONE to NO_CACHE #16650

merged 8 commits into from
Jan 9, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jan 8, 2025

We've seen multiple get users get confused about the NONE cache policy, thinking that passing the Python None is sufficient to engage this policy. To avoid this confusion, this PR proposes renaming NONE to NO_CACHE to be explicit, updates docs accordingly, and keeps NONE around to avoid any breaking changes.

cc: @gabcoyne

@cicdw cicdw added the enhancement An improvement of an existing feature label Jan 8, 2025
@github-actions github-actions bot added docs ui-replatform Related to the React UI rewrite labels Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #16650 will improve performances by 14.44%

Comparing none-to-no-cache (34a0082) with main (ada6eee)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark main none-to-no-cache Change
bench_flow_decorator 5.3 ms 4.6 ms +14.44%

@desertaxle desertaxle removed the ui-replatform Related to the React UI rewrite label Jan 9, 2025
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@cicdw cicdw merged commit 5b11e56 into main Jan 9, 2025
48 checks passed
@cicdw cicdw deleted the none-to-no-cache branch January 9, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants