Add controller for CRON tasks and minor fixes #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hlavtox
force-pushed
the
minor-bugfixes
branch
from
2557350 to
629222a
Compare
6 tasks
ShaiMagal
approved these changes
Jan 5, 2024
boherm
approved these changes
Jan 8, 2024
matks
approved these changes
Jan 8, 2024
| */ | ||
| trigger_error('This file should no longer be used and will be removed in 5.0.0 version of this module. Please update your cron tasks to use the new URL available in module settings.', E_USER_NOTICE); |
There was a problem hiding this comment.
No Tools::displayFileAsDeprecated() ?
There was a problem hiding this comment.
I looked into it, but I didn't like that you can't specify the message and it throws the error only in debug mode.
|
Hi @Hlavtox Thank you for your PR, I tested it and it seems to works as you can see : recording.47.webmAs you can see on the start there is a little message about the version of PHP that is not supported and we have a red notice, except that all seems to works. Tested on 8.1.x and develop, red message : Because the PR seems to works as expected, if this error message is not problematic for you, It's QA ✔️ Thank you |
|
No that message is something unrelated to the project. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://localhost/dev/modules/gsitemap/gsitemap-cron.php?token=YOURTOKEN&id_shop=1