Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module GET endpoint and bulk PUT for status #20

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Mar 21, 2024

Questions Answers
Description? Add module GET endpoint and bulk PUT for status, also add paginated list
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? ~
Sponsor company ~
How to test? ~

@jolelievre jolelievre closed this Mar 26, 2024
@jolelievre jolelievre reopened this Mar 26, 2024
@jolelievre jolelievre requested a review from tleon March 26, 2024 17:04
*
* NOTICE OF LICENSE
*
* This source file is subject to the Open Software License (OSL 3.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFL not OSL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right but it's wrong in the whole module actually, I'll do a dedicated PR after to fix it all

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but a PR to fix licensing will be needed afterwards

@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Mar 26, 2024
@jolelievre jolelievre merged commit 255bb95 into PrestaShop:dev Mar 27, 2024
10 of 12 checks passed
@jolelievre jolelievre removed the Waiting for QA Status: Waiting for QA feedback label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants