Chore(api): change query builder named parameter #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tleon
commented
Apr 4, 2024
tleon
commented
| Questions | Answers |
|---|---|
| Description? | Change named parameter in the module |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #35686 |
| Sponsor company | PrestaShop SA |
| How to test? | CI 🟢 |
jolelievre
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Thanks @tleon
All good, except for the services that should be moved from the core into here (see comment on the core PR)
tleon
force-pushed
the
Issue-35686-make-api-based-on-grid
branch
from
be601c7 to
aaf8cfe
Compare
jolelievre
reviewed
Apr 11, 2024
config/admin/services.yml
Outdated
Comment on lines
6
to
7
| prestashop.module.api.list.module_query_builder: | ||
| class: 'PrestaShop\Module\APIResources\List\ModuleQueryBuilder' |
There was a problem hiding this comment.
Suggested change
| prestashop.module.api.list.module_query_builder: | |
| class: 'PrestaShop\Module\APIResources\List\ModuleQueryBuilder' | |
| PrestaShop\Module\APIResources\List\ModuleQueryBuilder: |
There was a problem hiding this comment.
You can, and should, still rely on FQCN as the service name
config/admin/services.yml
Outdated
| class: '%prestashop.core.grid.data.factory.doctrine_grid_data_factory%' | ||
| public: true | ||
| arguments: | ||
| - '@prestashop.module.api.list.module_query_builder' |
There was a problem hiding this comment.
Suggested change
| - '@prestashop.module.api.list.module_query_builder' | |
| - '@PrestaShop\Module\APIResources\List\ModuleQueryBuilder' |
tleon
force-pushed
the
Issue-35686-make-api-based-on-grid
branch
2 times, most recently
from
472de9b to
be0cf1e
Compare
jolelievre
previously approved these changes
Apr 11, 2024
tleon
force-pushed
the
Issue-35686-make-api-based-on-grid
branch
from
be0cf1e to
da15335
Compare
tleon
changed the title
jolelievre
previously approved these changes
Apr 11, 2024
tleon
force-pushed
the
Issue-35686-make-api-based-on-grid
branch
from
da15335 to
a2720b6
Compare
jolelievre
previously approved these changes
Apr 11, 2024
boherm
previously approved these changes
Apr 12, 2024
tleon
force-pushed
the
Issue-35686-make-api-based-on-grid
branch
from
a2720b6 to
d949f68
Compare
jolelievre
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.