Handle localized values based on locale instead of IDs #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolelievre
changed the title
jolelievre
force-pushed
the
localized-values
branch
from
2361956 to
9808ef6
Compare
boherm
approved these changes
Dec 16, 2024
|
Hello @jolelievre, CI is red 😢 |
|
@paulnoelcholot yeah it's normal because it is linked to a PR on the core PrestaShop/PrestaShop#37633 The tests will remain red until the PR is merged, then we'll just have to relaunch the CI and this one will be mergeable (the module tests are launched on the core CI so we're sure they will be green) Sorry I should have removed the WAiting for QA label, these API PRs are 00% validated by automated tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewProductImage:productIdandProductImageList::productIdproperty to fix some casting problems- Adapt localized resources to rely on string locale values