{REFACTOR} Refactored API and service-layer classes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class that contains factory methods
… DeviceResolver class
…eviceArgsResolver class
…ontroller to TransferPlaybackDevicesResolver
…ack from controller to SwitchDeviceCommandArgsResolver
…yback from controller to TargetDeactivationDevicesResolver. Renamed test class to SwitchDevicesEndpointTest
…ntroller to AvailableDevicesResponseDtoConverter
…method from PUT to POST, changed URI to /player/devices instead of /player/device/connect
… /player/devices instead of /player/device/switch
…I to /player/devices instead of /player/device
…O, now method calls converter directly
…ayerStateService instead of Repo+converter
…oring of parts where PlayCommandContext#contextUri have been used
…hods to play resume playback in CurrentPlayerState
…grityValidator. Made refactor
…tity with domain model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored API by changing:
Moved creation of Command classes from controller to HandlerMethodArgumentResolver(s).
Moved methods that used to manipulate with player from entity to domain model(CurrentPlayerState).