Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Fixed bug when progress was calculated wrongly #71

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

justJavaProgrammer
Copy link
Contributor

@justJavaProgrammer justJavaProgrammer commented Aug 4, 2024

Fixed bug when progress was calculated wrongly because playStartTime, lastPauseTime weren't persisted to repository.
Added NOT FRAGILE unit tests for playback progress calculation by introducing Clock object.

…to PlayableItemDuration, fixed tests when Faker created PlayableItem with invalid duration, now tests do not fail(only if code not work as expected) and is not fragile
@justJavaProgrammer justJavaProgrammer added the enhancement New feature or request label Aug 4, 2024
@justJavaProgrammer justJavaProgrammer self-assigned this Aug 4, 2024
@justJavaProgrammer justJavaProgrammer merged commit 16b9dc2 into master Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant