Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Added endpoint to seek current playback position #73

Merged
merged 16 commits into from
Aug 21, 2024
Merged

[FEATURE] Added endpoint to seek current playback position #73

merged 16 commits into from
Aug 21, 2024

Conversation

justJavaProgrammer
Copy link
Contributor

Added HTTP endpoint to seek position to specified.

Http method: PUT
URI: /player/seek

Query parameters:

  • position - REQUIRED. integer, must be positive, a position greater than current track duration will cause an error
  • precision - OPTIONAL. case insensitive enum, one of: MILLIS, SECONDS. Default to millis. Precision is used to set the unit of time for seek position.

Response:

  • 204 NO CONTENT - command received
  • 400 BAD REQUEST - request is malformed, an error will be returned with reason code and human-readable description
  • 401 Unauthorized - missing access token

@justJavaProgrammer
Added seekTo method to CurrentPlayerState to seek the current player …
c62766f 
…position
@justJavaProgrammer
Moved getDuration to TimedItem and refactored SeekPosition to use Tim…
b4fd73e 
…edItem instead of PlayableItem
@justJavaProgrammer
Moved SeekToPositionTest.java to 'test/model' package
00ff7c1
@justJavaProgrammer
Removed 'TimedItem' and now using PlayableItemDuration in SeekPositio…
6d02705 
…n.exceeds() method
@justJavaProgrammer
Added new 'seekToPosition()' method to DefaultPlayerOperations, added…
0b09f25 
… tests
@justJavaProgrammer
Removed conditions from executeChangeVolumeCommand and inline it
2a74906
@justJavaProgrammer
Replaced 'withShuffleState' to 'switchShuffleMode' method to make the…
da816cc 
… shuffle mode encapsulated
@justJavaProgrammer
Removed 'getDeviceOperations' from BasicPlayerOperations
95fb2b7
@justJavaProgrammer
Push 'seekToPosition' method up to interface
9b33e10
@justJavaProgrammer
Added base support for HTTP endpoint to seek playback
37aa477
@justJavaProgrammer
Added support to return error if seek position exceeds track duration
1b33118
@justJavaProgrammer
Added support for seek precision. default is MILLIS
dbd9dda
@justJavaProgrammer
Refactoring of PlayerController, moved creation of SeekPosition to Se…
087115a 
…ekPositionResolver.java
@justJavaProgrammer
Ignored test is passing successfully now
10020b9
@justJavaProgrammer
Fixed failing test when Faker creating duration less than required.
91060d3
@justJavaProgrammer
Added tests to send event on seek command
63270ae
@justJavaProgrammer justJavaProgrammer added the enhancement New feature or request label Aug 21, 2024
@justJavaProgrammer justJavaProgrammer self-assigned this Aug 21, 2024
@justJavaProgrammer justJavaProgrammer linked an issue Aug 21, 2024 that may be closed by this pull request
[FEATURE] Add endpoint to seek playback to specific position #72
Closed
@justJavaProgrammer justJavaProgrammer merged commit cacea72 into master Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justJavaProgrammer justJavaProgrammer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add endpoint to seek playback to specific position
1 participant
@justJavaProgrammer