Merge pull request #37 from Proof-Of-Humanity/review-harmeet

Add Harman-singh-waraich to RAB pragma
Proof-Of-Humanity · Aug 16, 2024 · b6ebad4 · b6ebad4
2 parents 5ce345f + 9d0bf0e
commit b6ebad4
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/contracts/CrossChainProofOfHumanity.sol b/contracts/CrossChainProofOfHumanity.sol
@@ -1,5 +1,5 @@
 /** @authors: [@andreimvp]
- *  @reviewers: [@unknownunknown1*, @fnanni-0*, @hrishibhat*, @divyangchauhan]
+ *  @reviewers: [@unknownunknown1*, @fnanni-0*, @hrishibhat*, @divyangchauhan, @Harman-singh-waraich]
  *  @auditors: []
  *  @bounties: []
  *  @deployments: []

diff --git a/contracts/ProofOfHumanity.sol b/contracts/ProofOfHumanity.sol
@@ -1,5 +1,5 @@
 /** @authors: [@andreimvp]
- *  @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan]
+ *  @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan, @Harman-singh-waraich]
  *  @auditors: []
  *  @bounties: []
  *  @deployments: []
@@ -355,15 +355,15 @@ contract ProofOfHumanity is IProofOfHumanity, IArbitrable, IEvidence {
         uint256 disputeId
     );
 
-    /** @dev Emitted when humanity is succesfully claimed.
+    /** @dev Emitted when humanity is successfully claimed.
      *  @param humanityId The humanity ID.
-     *  @param requestId The ID of the succesfull request.
+     *  @param requestId The ID of the successfull request.
      */
     event HumanityClaimed(bytes20 humanityId, uint256 requestId);
 
-    /** @dev Emitted when humanity is succesfully revoked.
+    /** @dev Emitted when humanity is successfully revoked.
      *  @param humanityId The humanity ID.
-     *  @param requestId The ID of the succesfull request.
+     *  @param requestId The ID of the successfull request.
      */
     event HumanityRevoked(bytes20 humanityId, uint256 requestId);
 
@@ -374,7 +374,7 @@ contract ProofOfHumanity is IProofOfHumanity, IArbitrable, IEvidence {
      */
     event VouchesProcessed(bytes20 humanityId, uint256 requestId, uint256 endIndex);
 
-    /** @dev Emitted when the challenge period is restarted after an unsuccesful challenge.
+    /** @dev Emitted when the challenge period is restarted after an unsuccessful challenge.
      *  @param humanityId The humanity ID.
      *  @param requestId The ID of the request.
      *  @param challengeId The ID of the challenge.

diff --git a/contracts/extending-old/ForkModule.sol b/contracts/extending-old/ForkModule.sol
@@ -1,5 +1,5 @@
 /** @authors: []
- *  @reviewers: [@divyangchauhan]
+ *  @reviewers: [@divyangchauhan, @Harman-singh-waraich]
  *  @auditors: []
  *  @bounties: []
  *  @deployments: []
@@ -94,7 +94,7 @@ contract ForkModule is IForkModule {
      *  - Submission must be registered in v1.
      *
      *  @param _submissionID Address corresponding to the human.
-     *  @return expirationTime Expiration time of the revoked humanity. Used for.
+     *  @return expirationTime Expiration time of the revoked humanity.
      */
     function tryRemove(address _submissionID) external override onlyV2 returns (uint40 expirationTime) {
         require(!removed[_submissionID], "removed!");

diff --git a/contracts/extending-old/ProofOfHumanityExtended.sol b/contracts/extending-old/ProofOfHumanityExtended.sol
@@ -1,5 +1,5 @@
 /** @authors: [@andreimvp]
- *  @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan]
+ *  @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan, @Harman-singh-waraich]
  *  @auditors: []
  *  @bounties: []
  *  @deployments: []
@@ -358,15 +358,15 @@ contract ProofOfHumanityExtended is IProofOfHumanity, IArbitrable, IEvidence {
         uint256 disputeId
     );
 
-    /** @dev Emitted when humanity is succesfully claimed.
+    /** @dev Emitted when humanity is successfully claimed.
      *  @param humanityId The humanity ID.
-     *  @param requestId The ID of the succesfull request.
+     *  @param requestId The ID of the successfull request.
      */
     event HumanityClaimed(bytes20 humanityId, uint256 requestId);
 
-    /** @dev Emitted when humanity is succesfully revoked.
+    /** @dev Emitted when humanity is successfully revoked.
      *  @param humanityId The humanity ID.
-     *  @param requestId The ID of the succesfull request.
+     *  @param requestId The ID of the successfull request.
      */
     event HumanityRevoked(bytes20 humanityId, uint256 requestId);
 
@@ -377,7 +377,7 @@ contract ProofOfHumanityExtended is IProofOfHumanity, IArbitrable, IEvidence {
      */
     event VouchesProcessed(bytes20 humanityId, uint256 requestId, uint256 endIndex);
 
-    /** @dev Emitted when the challenge period is restarted after an unsuccesful challenge.
+    /** @dev Emitted when the challenge period is restarted after an unsuccessful challenge.
      *  @param humanityId The humanity ID.
      *  @param requestId The ID of the request.
      *  @param challengeId The ID of the challenge.