Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harman-singh-waraich to RAB pragma #37

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Add Harman-singh-waraich to RAB pragma #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
123c2bd
fix: successfully-spelling
Harman-singh-waraich Aug 16, 2024
125bce9
fix: incomplete comment
Harman-singh-waraich Aug 16, 2024
8bdfea5
docs: added Harman-singh-waraich to RAB pragma
Harman-singh-waraich Aug 16, 2024
07ae595
docs: update-poh-extended-RAB-pragma
Harman-singh-waraich Aug 16, 2024
9d0bf0e
Merge branch 'master' into review-harmeet
martillansky Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/CrossChainProofOfHumanity.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @authors: [@andreimvp]
* @reviewers: [@unknownunknown1*, @fnanni-0*, @hrishibhat*, @divyangchauhan]
* @reviewers: [@unknownunknown1*, @fnanni-0*, @hrishibhat*, @divyangchauhan, @Harman-singh-waraich]
* @auditors: []
* @bounties: []
* @deployments: []
Expand Down
12 changes: 6 additions & 6 deletions contracts/ProofOfHumanity.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @authors: [@andreimvp]
* @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan]
* @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan, @Harman-singh-waraich]
* @auditors: []
* @bounties: []
* @deployments: []
Expand Down Expand Up @@ -355,15 +355,15 @@ contract ProofOfHumanity is IProofOfHumanity, IArbitrable, IEvidence {
uint256 disputeId
);

/** @dev Emitted when humanity is succesfully claimed.
/** @dev Emitted when humanity is successfully claimed.
* @param humanityId The humanity ID.
* @param requestId The ID of the succesfull request.
* @param requestId The ID of the successfull request.
*/
event HumanityClaimed(bytes20 humanityId, uint256 requestId);

/** @dev Emitted when humanity is succesfully revoked.
/** @dev Emitted when humanity is successfully revoked.
* @param humanityId The humanity ID.
* @param requestId The ID of the succesfull request.
* @param requestId The ID of the successfull request.
*/
event HumanityRevoked(bytes20 humanityId, uint256 requestId);

Expand All @@ -374,7 +374,7 @@ contract ProofOfHumanity is IProofOfHumanity, IArbitrable, IEvidence {
*/
event VouchesProcessed(bytes20 humanityId, uint256 requestId, uint256 endIndex);

/** @dev Emitted when the challenge period is restarted after an unsuccesful challenge.
/** @dev Emitted when the challenge period is restarted after an unsuccessful challenge.
* @param humanityId The humanity ID.
* @param requestId The ID of the request.
* @param challengeId The ID of the challenge.
Expand Down
4 changes: 2 additions & 2 deletions contracts/extending-old/ForkModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @authors: []
* @reviewers: [@divyangchauhan]
* @reviewers: [@divyangchauhan, @Harman-singh-waraich]
* @auditors: []
* @bounties: []
* @deployments: []
Expand Down Expand Up @@ -94,7 +94,7 @@ contract ForkModule is IForkModule {
* - Submission must be registered in v1.
*
* @param _submissionID Address corresponding to the human.
* @return expirationTime Expiration time of the revoked humanity. Used for.
* @return expirationTime Expiration time of the revoked humanity.
*/
function tryRemove(address _submissionID) external override onlyV2 returns (uint40 expirationTime) {
require(!removed[_submissionID], "removed!");
Expand Down
12 changes: 6 additions & 6 deletions contracts/extending-old/ProofOfHumanityExtended.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @authors: [@andreimvp]
* @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan]
* @reviewers: [@unknownunknown1, @shotaronowhere*, @gratestas, Param, @fnanni-0*, @divyangchauhan, @Harman-singh-waraich]
* @auditors: []
* @bounties: []
* @deployments: []
Expand Down Expand Up @@ -358,15 +358,15 @@ contract ProofOfHumanityExtended is IProofOfHumanity, IArbitrable, IEvidence {
uint256 disputeId
);

/** @dev Emitted when humanity is succesfully claimed.
/** @dev Emitted when humanity is successfully claimed.
* @param humanityId The humanity ID.
* @param requestId The ID of the succesfull request.
* @param requestId The ID of the successfull request.
*/
event HumanityClaimed(bytes20 humanityId, uint256 requestId);

/** @dev Emitted when humanity is succesfully revoked.
/** @dev Emitted when humanity is successfully revoked.
* @param humanityId The humanity ID.
* @param requestId The ID of the succesfull request.
* @param requestId The ID of the successfull request.
*/
event HumanityRevoked(bytes20 humanityId, uint256 requestId);

Expand All @@ -377,7 +377,7 @@ contract ProofOfHumanityExtended is IProofOfHumanity, IArbitrable, IEvidence {
*/
event VouchesProcessed(bytes20 humanityId, uint256 requestId, uint256 endIndex);

/** @dev Emitted when the challenge period is restarted after an unsuccesful challenge.
/** @dev Emitted when the challenge period is restarted after an unsuccessful challenge.
* @param humanityId The humanity ID.
* @param requestId The ID of the request.
* @param challengeId The ID of the challenge.
Expand Down
Loading