-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE - Bespoke work for Moray - Forres and Lossiemouth #76
Draft
Moohan
wants to merge
53
commits into
development
Choose a base branch
from
bespoke/forres_and_lossiemouth
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moohan
force-pushed
the
bespoke/forres_and_lossiemouth
branch
from
May 6, 2024 16:54
85060a9
to
bb77728
Compare
This function aggregates the data from IZ level to the new 'locality' boundaries, it tries to properly recompute the CI when the values are available.
This will return the Moray specific lookup
This will likely need doing for other data too...
Moohan
force-pushed
the
bespoke/forres_and_lossiemouth
branch
from
May 14, 2024 07:23
c4112b5
to
bb05c02
Compare
Not needed
Some are already loaded with `library(tidyverse)`
…alth-Scotland/list-localities-profiles into bespoke/forres_and_lossiemouth
cfraser2020
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not actually sure where this came from as i had to pull/push before being able to commit my suggested change before
Master RMarkdown Document & Render Code/overwrite_with_custom_functions.R
Outdated
Show resolved
Hide resolved
This will inevitably be left on the drive occupying space and these files also had patient-level data, which isn't ideal!
I had a chat with @CliveWG and discovered the measure calculation was incorrect. Pretty sure this is now correct...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress, just adding as a PR so it's easy to see the changes I've made so far.